Changeset e5a1ace3 in mainline for uspace/lib/ext4/libext4_balloc.c

Timestamp:

2013-11-28T20:40:38Z (10 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1f63d9d

Parents:

532f53d

Message:

libext4: do not ignore error codes

File:

• uspace/lib/ext4/libext4_balloc.c (modified) (4 diffs)

uspace/lib/ext4/libext4_balloc.c

@@ -328 +328 @@
         *goal = inode_table_first_block + inode_table_blocks;
         
-        ext4_filesystem_put_block_group_ref(bg_ref);
-        
-        return EOK;
+        return ext4_filesystem_put_block_group_ref(bg_ref);
 }
 
@@ -469 +467 @@
         
         /* No free block found yet */
-        block_put(bitmap_block);
-        ext4_filesystem_put_block_group_ref(bg_ref);
+        rc = block_put(bitmap_block);
+        if (rc != EOK) {
+                ext4_filesystem_put_block_group_ref(bg_ref);
+                return rc;
+        }
+
+        rc = ext4_filesystem_put_block_group_ref(bg_ref);
+        if (rc != EOK)
+                return rc;
         
         /* Try other block groups */
@@ -540 +545 @@
                 }
                 
-                block_put(bitmap_block);
+                rc = block_put(bitmap_block);
+                if (rc != EOK) {
+                        ext4_filesystem_put_block_group_ref(bg_ref);
+                        return rc;
+                }
+
                 ext4_filesystem_put_block_group_ref(bg_ref);
+                if (rc != EOK)
+                        return rc;
                 
                 /* Goto next group */
@@ -576 +588 @@
         bg_ref->dirty = true;
         
-        ext4_filesystem_put_block_group_ref(bg_ref);
+        rc = ext4_filesystem_put_block_group_ref(bg_ref);
         
         *fblock = allocated_block;
-        return EOK;
+        return rc;
 }