Changeset 532f53d in mainline

Timestamp:

2013-11-20T21:47:41Z (10 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e5a1ace3

Parents:

2764497

Message:

ext4: return the error code to the caller in case something fails.

Location:

uspace

Files:

• lib/ext4/libext4_extent.c (modified) (10 diffs)
• lib/ext4/libext4_filesystem.c (modified) (3 diffs)
• srv/fs/ext4fs/ext4fs_ops.c (modified) (13 diffs)

uspace/lib/ext4/libext4_extent.c

@@ -371 +371 @@
     uint32_t *fblock)
 {
+        int rc;
         /* Compute bound defined by i-node size */
         uint64_t inode_size =
@@ -400 +401 @@
                 uint64_t child = ext4_extent_index_get_leaf(index);
                 
-                if (block != NULL)
-                        block_put(block);
-                
-                int rc = block_get(&block, inode_ref->fs->device, child,
+                if (block != NULL) {
+                        rc = block_put(block);
+                        if (rc != EOK)
+                                return rc;
+                }
+                
+                rc = block_get(&block, inode_ref->fs->device, child,
                     BLOCK_FLAGS_NONE);
                 if (rc != EOK)
@@ -429 +433 @@
         /* Cleanup */
         if (block != NULL)
-                block_put(block);
-        
-        return EOK;
+                rc = block_put(block);
+        
+        return rc;
 }
 
@@ -505 +509 @@
         
 cleanup:
+        ;
+
+        int rc2 = EOK;
+
         /*
          * Put loaded blocks
@@ -510 +518 @@
          */
         for (uint16_t i = 1; i < tmp_path->depth; ++i) {
-                if (tmp_path[i].block)
-                        block_put(tmp_path[i].block);
+                if (tmp_path[i].block) {
+                        rc2 = block_put(tmp_path[i].block);
+                        if (rc == EOK && rc2 != EOK)
+                                rc = rc2;
+                }
         }
         
@@ -594 +605 @@
                 return rc;
         
-        ext4_balloc_free_block(inode_ref, fblock);
-        
-        return EOK;
+        return ext4_balloc_free_block(inode_ref, fblock);
 }
 
@@ -721 +730 @@
         
 cleanup:
+        ;
+
+        int rc2 = EOK;
+
         /*
          * Put loaded blocks
@@ -726 +739 @@
          */
         for (uint16_t i = 1; i <= path->depth; ++i) {
-                if (path[i].block)
-                        block_put(path[i].block);
+                if (path[i].block) {
+                        rc2 = block_put(path[i].block);
+                        if (rc == EOK && rc2 != EOK)
+                                rc = rc2;
+                }
         }
         
@@ -1061 +1077 @@
         
 finish:
+        ;
+
+        int rc2 = EOK;
+
         /* Set return values */
         *iblock = new_block_idx;
@@ -1070 +1090 @@
          */
         for (uint16_t i = 1; i <= path->depth; ++i) {
-                if (path[i].block)
-                        block_put(path[i].block);
+                if (path[i].block) {
+                        rc2 = block_put(path[i].block);
+                        if (rc == EOK && rc2 != EOK)
+                                rc = rc2;
+                }
         }
         

uspace/lib/ext4/libext4_filesystem.c

@@ -797 +797 @@
                 }
                 
-                block_put(block);
+                rc = block_put(block);
+                if (rc != EOK)
+                        return rc;
+
                 rc = ext4_balloc_free_block(inode_ref, fblock);
                 if (rc != EOK)
@@ -841 +844 @@
                                 }
                                 
-                                block_put(subblock);
+                                rc = block_put(subblock);
+                                if (rc != EOK)
+                                        return rc;
                         }
                         
@@ -851 +856 @@
                 }
                 
-                block_put(block);
+                rc = block_put(block);
+                if (rc != EOK)
+                        return rc;
+
                 rc = ext4_balloc_free_block(inode_ref, fblock);
                 if (rc != EOK)

uspace/srv/fs/ext4fs/ext4fs_ops.c

@@ -259 +259 @@
         rc = ext4fs_node_get_core(rfn, eparent->instance, inode);
         if (rc != EOK)
-                return rc;
-        
+                goto exit;
+
+exit:
+        ;
+
         /* Destroy search result structure */
-        return ext4_directory_destroy_result(&result);
+        int const rc2 = ext4_directory_destroy_result(&result);
+        return rc == EOK ? rc2 : rc;
 }
 
@@ -1002 +1006 @@
         *lnkcnt = 1;
         
-        ext4fs_node_put(root_node);
-        
-        return EOK;
+        return ext4fs_node_put(root_node);
 }
 
@@ -1093 +1095 @@
         }
         
-        ext4_filesystem_put_inode_ref(inode_ref);
-        
-        return rc;
+        int const rc2 = ext4_filesystem_put_inode_ref(inode_ref);
+        
+        return rc == EOK ? rc2 : rc;
 }
 
@@ -1268 +1270 @@
                 memset(buffer, 0, bytes);
                 
-                async_data_read_finalize(callid, buffer, bytes);
+                rc = async_data_read_finalize(callid, buffer, bytes);
                 *rbytes = bytes;
                 
                 free(buffer);
-                return EOK;
+                return rc;
         }
         
@@ -1284 +1286 @@
         
         assert(offset_in_block + bytes <= block_size);
-        async_data_read_finalize(callid, block->data + offset_in_block, bytes);
+        rc = async_data_read_finalize(callid, block->data + offset_in_block, bytes);
+        if (rc != EOK) {
+                block_put(block);
+                return rc;
+        }
         
         rc = block_put(block);
@@ -1316 +1322 @@
         size_t len;
         if (!async_data_write_receive(&callid, &len)) {
-                ext4fs_node_put(fn);
-                async_answer_0(callid, EINVAL);
-                return EINVAL;
+                rc = EINVAL;
+                async_answer_0(callid, rc);
+                goto exit;
         }
         
@@ -1341 +1347 @@
             &fblock);
         if (rc != EOK) {
-                ext4fs_node_put(fn);
                 async_answer_0(callid, rc);
-                return rc;
+                goto exit;
         }
         
@@ -1359 +1364 @@
                                     &fblock, true);
                                 if (rc != EOK) {
-                                        ext4fs_node_put(fn);
                                         async_answer_0(callid, rc);
-                                        return rc;
+                                        goto exit;
                                 }
                         }
@@ -1368 +1372 @@
                             &fblock, false);
                         if (rc != EOK) {
-                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                return rc;
+                                goto exit;
                         }
                 } else {
                         rc = ext4_balloc_alloc_block(inode_ref, &fblock);
                         if (rc != EOK) {
-                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                return rc;
+                                goto exit;
                         }
                         
@@ -1384 +1386 @@
                         if (rc != EOK) {
                                 ext4_balloc_free_block(inode_ref, fblock);
-                                ext4fs_node_put(fn);
                                 async_answer_0(callid, rc);
-                                return rc;
+                                goto exit;
                         }
                 }
@@ -1398 +1399 @@
         rc = block_get(&write_block, service_id, fblock, flags);
         if (rc != EOK) {
-                ext4fs_node_put(fn);
                 async_answer_0(callid, rc);
-                return rc;
+                goto exit;
         }
         
         if (flags == BLOCK_FLAGS_NOREAD)
                 memset(write_block->data, 0, block_size);
-        
+
         rc = async_data_write_finalize(callid, write_block->data +
             (pos % block_size), bytes);
-        if (rc != EOK) {
-                ext4fs_node_put(fn);
-                return rc;
-        }
-        
+        if (rc != EOK)
+                goto exit;
+
         write_block->dirty = true;
         
         rc = block_put(write_block);
-        if (rc != EOK) {
-                ext4fs_node_put(fn);
-                return rc;
-        }
-        
+        if (rc != EOK)
+                goto exit;
+
         /* Do some counting */
         uint32_t old_inode_size = ext4_inode_get_size(fs->superblock,
@@ -1428 +1424 @@
                 inode_ref->dirty = true;
         }
-        
+
         *nsize = ext4_inode_get_size(fs->superblock, inode_ref->inode);
         *wbytes = bytes;
-        
-        return ext4fs_node_put(fn);
+
+exit:
+        ;
+
+        int const rc2 = ext4fs_node_put(fn);
+        return rc == EOK ? rc2 : rc;
 }
 
@@ -1458 +1458 @@
         
         rc = ext4_filesystem_truncate_inode(inode_ref, new_size);
-        ext4fs_node_put(fn);
-        
-        return rc;
+        int const rc2 = ext4fs_node_put(fn);
+        
+        return rc == EOK ? rc2 : rc;
 }