Changeset 747ef72 in mainline for uspace/drv/bus/usb/usbhid/kbd/kbdrepeat.c

Timestamp:

2011-11-10T11:29:10Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

54464f6a, c2245a3, c6f189f7

Parents:

2e1b9dc (diff), 2d1ba51 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge USB changes.

Interface changes:

• GET_ADDRESS has been renamed to GET_MY_ADDRESS and the handle parameter was dropped. Tis call no longer cascades up to the root hub, but it is answered in the first place the information is available (nearest hub)
• Reintroduced address reservation for USB_DEFAULT_ADDRESS. The interface now enables device drivers to request specific address on initialization and either insists on that address or accept any other if the address is not available. Note that it is not possible to get the default address if the driver does not insist.
• Any endpoint registered is removed when address is released and a warning is produced if there were any such endpoints.
• It is no longer necessary or possible to pass device speed information when registering endpoints.

Driver fixes: memory leaks and crashes (not only) in error paths.
Fixes or removes flaky device_remove implementation in device drivers.

File:

• uspace/drv/bus/usb/usbhid/kbd/kbdrepeat.c (modified) (10 diffs)

uspace/drv/bus/usb/usbhid/kbd/kbdrepeat.c

@@ -45 +45 @@
 #include "kbddev.h"
 
-
-
-/*----------------------------------------------------------------------------*/
 /**
  * Main loop handling the auto-repeat of keys.
@@ -58 +55 @@
  * If the same key is still pressed, it uses the delay between repeats stored
  * in the keyboard structure to wait until the key should be repeated.
- * 
+ *
  * If the currently repeated key is not pressed any more (
- * usb_kbd_repeat_stop() was called), it stops repeating it and starts 
+ * usb_kbd_repeat_stop() was called), it stops repeating it and starts
  * checking again.
  *
  * @note For accessing the keyboard device auto-repeat information a fibril
  *       mutex (repeat_mtx) from the @a kbd structure is used.
- * 
+ *
  * @param kbd Keyboard device structure.
  */
@@ -75 +72 @@
 
         while (true) {
-                // check if the kbd structure is usable
+                /* Check if the kbd structure is usable. */
                 if (!usb_kbd_is_initialized(kbd)) {
                         usb_log_warning("kbd not ready, exiting autorepeat.\n");
                         return;
                 }
-                
+
                 fibril_mutex_lock(&kbd->repeat_mtx);
 
                 if (kbd->repeat.key_new > 0) {
                         if (kbd->repeat.key_new == kbd->repeat.key_repeated) {
-                                usb_log_debug2("Repeating key: %u.\n", 
+                                usb_log_debug2("Repeating key: %u.\n",
                                     kbd->repeat.key_repeated);
-                                // ugly hack with the NULL
-                                usb_kbd_push_ev(NULL, kbd, KEY_PRESS, 
+                                usb_kbd_push_ev(kbd, KEY_PRESS,
                                     kbd->repeat.key_repeated);
                                 delay = kbd->repeat.delay_between;
@@ -106 +102 @@
                 }
                 fibril_mutex_unlock(&kbd->repeat_mtx);
-                
                 async_usleep(delay);
         }
 }
-
 /*----------------------------------------------------------------------------*/
 /**
@@ -116 +110 @@
  *
  * Starts the loop for checking changes in auto-repeat.
- * 
+ *
  * @param arg User-specified argument. Expects pointer to the keyboard device
  *            structure representing the keyboard.
@@ -132 +126 @@
         }
 
-        usb_kbd_t *kbd = (usb_kbd_t *)arg;
+        usb_kbd_t *kbd = arg;
 
         usb_kbd_repeat_loop(kbd);
@@ -138 +132 @@
         return EOK;
 }
-
 /*----------------------------------------------------------------------------*/
 /**
@@ -156 +149 @@
         fibril_mutex_unlock(&kbd->repeat_mtx);
 }
-
 /*----------------------------------------------------------------------------*/
 /**
@@ -162 +154 @@
  *
  * @note Only one key is repeated at any time, but this function may be called
- *       even with key that is not currently repeated (in that case nothing 
+ *       even with key that is not currently repeated (in that case nothing
  *       happens).
  *
@@ -176 +168 @@
         fibril_mutex_unlock(&kbd->repeat_mtx);
 }
-
 /**
  * @}