Changeset 65eac7b in mainline for uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h

Timestamp:

2012-02-24T03:08:24Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

668a2e8

Parents:

4e30369

Message:

ohci: Use endain aware access to manipulate memory structures.

Enable work queues

File:

• uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h (modified) (7 diffs)

uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.h

@@ -40 +40 @@
 #include <usb/host/endpoint.h>
 
+#include "../ohci_regs.h"
 #include "../utils/malloc32.h"
 #include "transfer_descriptor.h"
@@ -116 +117 @@
 {
         assert(instance);
-        return (instance->td_head & ED_TDHEAD_HALTED_FLAG)
-            || (instance->status & ED_STATUS_K_FLAG);
+        return (OHCI_RD(instance->td_head) & ED_TDHEAD_HALTED_FLAG)
+            || (OHCI_RD(instance->status) & ED_STATUS_K_FLAG);
+}
+
+static inline void ed_clear_halt(ed_t *instance)
+{
+        assert(instance);
+        OHCI_CLR(instance->td_head, ED_TDHEAD_HALTED_FLAG);
 }
 
@@ -128 +135 @@
 {
         assert(instance);
-        return (instance->td_head & ED_TDHEAD_PTR_MASK)
-            != (instance->td_tail & ED_TDTAIL_PTR_MASK);
+        return (OHCI_RD(instance->td_head) & ED_TDHEAD_PTR_MASK)
+            != (OHCI_RD(instance->td_tail) & ED_TDTAIL_PTR_MASK);
 }
 
@@ -141 +148 @@
         assert(instance);
         const uintptr_t pa = addr_to_phys(td);
-        instance->td_tail = pa & ED_TDTAIL_PTR_MASK;
+        OHCI_WR(instance->td_tail, pa & ED_TDTAIL_PTR_MASK);
+}
+
+static inline uint32_t ed_tail_td(const ed_t *instance)
+{
+        assert(instance);
+        return OHCI_RD(instance->td_tail) & ED_TDTAIL_PTR_MASK;
+}
+
+static inline uint32_t ed_head_td(const ed_t *instance)
+{
+        assert(instance);
+        return OHCI_RD(instance->td_head) & ED_TDHEAD_PTR_MASK;
 }
 
@@ -155 +174 @@
         const uint32_t pa = addr_to_phys(next);
         assert((pa & ED_NEXT_PTR_MASK) << ED_NEXT_PTR_SHIFT == pa);
-        instance->next = pa;
+        OHCI_WR(instance->next, pa);
 }
 
@@ -166 +185 @@
 {
         assert(instance);
-        return (instance->td_head & ED_TDHEAD_TOGGLE_CARRY) ? 1 : 0;
+        return (OHCI_RD(instance->td_head) & ED_TDHEAD_TOGGLE_CARRY) ? 1 : 0;
 }
 
@@ -178 +197 @@
         assert(instance);
         if (toggle) {
-                instance->td_head |= ED_TDHEAD_TOGGLE_CARRY;
+                OHCI_SET(instance->td_head, ED_TDHEAD_TOGGLE_CARRY);
         } else {
                 /* Clear halted flag when reseting toggle TODO: Why? */
-                instance->td_head &= ~ED_TDHEAD_TOGGLE_CARRY;
-                instance->td_head &= ~ED_TDHEAD_HALTED_FLAG;
+                OHCI_CLR(instance->td_head, ED_TDHEAD_TOGGLE_CARRY);
+                OHCI_CLR(instance->td_head, ED_TDHEAD_HALTED_FLAG);
         }
 }