Changeset 5e801dc in mainline for uspace/srv/fs/locfs/locfs_ops.c

Timestamp:

2019-02-25T14:42:38Z (5 years ago)

Author:

GitHub <noreply@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a4e78743

Parents:

ee8d4d6

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-25 14:42:38)

git-committer:

GitHub <noreply@…> (2019-02-25 14:42:38)

Message:

Indicate and enforce constness of hash table key in certain functions (#158)

The assumption here is that modifying key in the hash/equal functions in something completely unexpected, and not something you would ever want to do intentionally, so it makes sense to disallow it entirely to get that extra level of checking.

File:

• uspace/srv/fs/locfs/locfs_ops.c (modified) (2 diffs)

uspace/srv/fs/locfs/locfs_ops.c

@@ -71 +71 @@
 /* Implementation of hash table interface for the nodes hash table. */
 
-static size_t services_key_hash(void *key)
-{
-        return *(service_id_t *)key;
+static size_t services_key_hash(const void *key)
+{
+        const service_id_t *k = key;
+        return *k;
 }
 
@@ -82 +83 @@
 }
 
-static bool services_key_equal(void *key, const ht_link_t *item)
-{
+static bool services_key_equal(const void *key, const ht_link_t *item)
+{
+        const service_id_t *k = key;
         service_t *dev = hash_table_get_inst(item, service_t, link);
-        return (dev->service_id == *(service_id_t *)key);
+        return (dev->service_id == *k);
 }