Changeset 454f1da in mainline for kernel/arch/sparc64/src/trap/interrupt.c

Timestamp:

2007-03-26T19:35:28Z (17 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5d7daff

Parents:

4638401

Message:

Reworked handling of illegal virtual aliases caused by frame reuse.
We moved the incomplete handling from backend's frame method to
backend's page_fault method. The page_fault method is the one that
can create an illegal alias if it writes the userspace frame using
kernel address with a different page color than the page to which is
this frame mapped in userspace. When we detect this, we do D-cache
shootdown on all processors (!!!).

If we add code that accesses userspace memory from kernel address
space, we will have to check for illegal virtual aliases at all such
places.

I tested this on a 4-way simulated E6500 and a real-world Ultra 5,
which has unfortunatelly only one processor.

This solves ticket #26.

File:

• kernel/arch/sparc64/src/trap/interrupt.c (modified) (2 diffs)

kernel/arch/sparc64/src/trap/interrupt.c

@@ -45 +45 @@
 #include <arch.h>
 #include <mm/tlb.h>
+#include <arch/mm/cache.h>
 #include <config.h>
 #include <synch/spinlock.h>
@@ -84 +85 @@
                 /*
                  * This is a cross-call.
-                 * data0 contains address of kernel function.
+                 * data0 contains address of the kernel function.
                  * We call the function only after we verify
-                 * it is on of the supported ones.
+                 * it is one of the supported ones.
                  */
 #ifdef CONFIG_SMP
                 if (data0 == (uintptr_t) tlb_shootdown_ipi_recv) {
                         tlb_shootdown_ipi_recv();
+#ifdef CONFIG_VIRT_IDX_DCACHE
+                } else if (data0 == (uintptr_t) dcache_shootdown_ipi_recv) {
+                        dcache_shootdown_ipi_recv();
+#endif
                 }
 #endif