Opened 16 years ago
Closed 16 years ago
#106 closed defect (fixed)
Wrong visuals for HelenOS/sparc64 simics framebuffer
| Reported by: | Jakub Jermář | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.4.1 |
| Component: | helenos/unspecified | Version: | mainline |
| Keywords: | Cc: | ||
| Blocker for: | Depends on: | ||
| See also: |
Description
I suspect that the change in the framebuffer code in revision 4669 (merge of the arm branch) made a change which broke the framebuffer settings for the simics framebuffer.
Index: trunk/kernel/genarch/src/fb/fb.c
===================================================================
--- a/trunk/kernel/genarch/src/fb/fb.c
+++ b/trunk/kernel/genarch/src/fb/fb.c
@@ -115,4 +115,11 @@
*((uint32_t *) dst)
= (BLUE(rgb, 8) << 16) | (GREEN(rgb, 8) << 8) | RED(rgb, 8);
+}
+
+static void rgb_8880(void *dst, uint32_t rgb)
+{
+ *((uint32_t *) dst)
+ = (RED(rgb, 8) << 24) | (GREEN(rgb, 8) << 16) | (BLUE(rgb, 8) << 8);
+
}
@@ -471,5 +478,5 @@
break;
case VISUAL_RGB_8_8_8_0:
- rgb_conv = rgb_888;
+ rgb_conv = rgb_8880;
pixelbytes = 4;
break;
As a result, the framebuffer is using wrong collors.
Note:
See TracTickets
for help on using tickets.

Fixed in revision 4676.