id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc	field_blocks	field_dependson	field_seealso
106	Wrong visuals for HelenOS/sparc64 simics framebuffer	Jakub Jermář		"I suspect that the change in the framebuffer code in revision 4669 (merge of the arm branch) made a change which broke the framebuffer settings for the simics framebuffer.


{{{
Index: trunk/kernel/genarch/src/fb/fb.c
===================================================================
--- a/trunk/kernel/genarch/src/fb/fb.c
+++ b/trunk/kernel/genarch/src/fb/fb.c
@@ -115,4 +115,11 @@
         *((uint32_t *) dst)
             = (BLUE(rgb, 8) << 16) | (GREEN(rgb, 8) << 8) | RED(rgb, 8);
+}
+
+static void rgb_8880(void *dst, uint32_t rgb)
+{
+        *((uint32_t *) dst)
+           = (RED(rgb, 8) << 24) | (GREEN(rgb, 8) << 16) | (BLUE(rgb, 8) << 8);
+
 }
 
@@ -471,5 +478,5 @@
                 break;
         case VISUAL_RGB_8_8_8_0:
-                rgb_conv = rgb_888;
+                rgb_conv = rgb_8880;
                 pixelbytes = 4;
                 break;
}}}

As a result, the framebuffer is using wrong collors."	defect	closed	major	0.4.1	helenos/unspecified	mainline	fixed