Changeset b0ae23f in mainline for uspace/lib/display/test/display.c

Timestamp:

2023-01-17T15:21:13Z (2 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a0d4afe

Parents:

46a47c0

git-author:

Jiri Svoboda <jiri@…> (2023-01-17 18:21:02)

git-committer:

Jiri Svoboda <jiri@…> (2023-01-17 15:21:13)

Message:

Change the correct pointer's shape when resizing window

The request to resize a window originates from the client. The display
server forces the cursor to a double-arrow shape regardless of whether
it is over the window or not, until the resize is done. This is to
make sure the cursor keeps that shape even if it moves outside of
the current boundaries of the window. With multiple pointers we need
to know which one to change. This is done by passing the pos_id from
button press event that starts the resize all the way to
ds_window_start_resize(). Then it needs to be stored in the window
structure for use when it is time to restore the cursor.

File:

• uspace/lib/display/test/display.c (modified) (10 diffs)

uspace/lib/display/test/display.c

@@ -63 +63 @@
 static errno_t test_window_get_max_rect(void *, sysarg_t, gfx_rect_t *);
 static errno_t test_window_resize_req(void *, sysarg_t, display_wnd_rsztype_t,
-    gfx_coord2_t *);
+    gfx_coord2_t *, sysarg_t);
 static errno_t test_window_resize(void *, sysarg_t, gfx_coord2_t *,
     gfx_rect_t *);
@@ -141 +141 @@
         display_wnd_rsztype_t resize_req_rsztype;
         gfx_coord2_t resize_req_pos;
+        sysarg_t resize_req_pos_id;
 
         bool window_resize_called;
@@ -831 +832 @@
         display_wnd_rsztype_t rsztype;
         gfx_coord2_t pos;
+        sysarg_t pos_id;
 
         async_set_fallback_port_handler(test_display_conn, &resp);
@@ -863 +865 @@
         pos.x = 42;
         pos.y = 43;
-
-        rc = display_window_resize_req(wnd, rsztype, &pos);
+        pos_id = 44;
+
+        rc = display_window_resize_req(wnd, rsztype, &pos, pos_id);
         PCUT_ASSERT_TRUE(resp.window_resize_req_called);
         PCUT_ASSERT_ERRNO_VAL(resp.rc, rc);
@@ -871 +874 @@
         PCUT_ASSERT_INT_EQUALS(pos.x, resp.resize_req_pos.x);
         PCUT_ASSERT_INT_EQUALS(pos.y, resp.resize_req_pos.y);
+        PCUT_ASSERT_INT_EQUALS(pos_id, resp.resize_req_pos_id);
 
         display_window_destroy(wnd);
@@ -889 +893 @@
         display_wnd_rsztype_t rsztype;
         gfx_coord2_t pos;
+        sysarg_t pos_id;
 
         async_set_fallback_port_handler(test_display_conn, &resp);
@@ -921 +926 @@
         pos.x = 42;
         pos.y = 43;
-
-        rc = display_window_resize_req(wnd, rsztype, &pos);
+        pos_id = 44;
+
+        rc = display_window_resize_req(wnd, rsztype, &pos, pos_id);
         PCUT_ASSERT_TRUE(resp.window_resize_req_called);
         PCUT_ASSERT_ERRNO_VAL(resp.rc, rc);
@@ -929 +935 @@
         PCUT_ASSERT_INT_EQUALS(pos.x, resp.resize_req_pos.x);
         PCUT_ASSERT_INT_EQUALS(pos.y, resp.resize_req_pos.y);
+        PCUT_ASSERT_INT_EQUALS(pos_id, resp.resize_req_pos_id);
 
         display_window_destroy(wnd);
@@ -2188 +2195 @@
 
 static errno_t test_window_resize_req(void *arg, sysarg_t wnd_id,
-    display_wnd_rsztype_t rsztype, gfx_coord2_t *pos)
+    display_wnd_rsztype_t rsztype, gfx_coord2_t *pos, sysarg_t pos_id)
 {
         test_response_t *resp = (test_response_t *) arg;
@@ -2196 +2203 @@
         resp->resize_req_wnd_id = wnd_id;
         resp->resize_req_pos = *pos;
+        resp->resize_req_pos_id = pos_id;
         return resp->rc;
 }