Changeset a35b458 in mainline for uspace/lib/c/generic/arg_parse.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/lib/c/generic/arg_parse.c

    r3061bc1 ra35b458  
    3939        if (str_cmp(arg, ashort) == 0)
    4040                return 0;
    41        
     41
    4242        if (str_lcmp(arg, along, str_length(along)) == 0)
    4343                return str_length(along);
    44        
     44
    4545        return -1;
    4646}
    … …  
    6969{
    7070        char *rest;
    71        
     71
    7272        if (offset)
    7373                *value = strtol(argv[*index] + offset, &rest, 10);
    … …  
    7777        } else
    7878                return ENOENT;
    79        
     79
    8080        if ((rest) && (*rest))
    8181                return EINVAL;
    82        
     82
    8383        return EOK;
    8484}
    … …  
    109109{
    110110        char *arg;
    111        
     111
    112112        errno_t ret = arg_parse_string(argc, argv, index, &arg, offset);
    113113        if (ret != EOK)
    114114                return ret;
    115        
     115
    116116        return parser(arg, value);
    117117}
    … …  
    145145        } else
    146146                return ENOENT;
    147        
     147
    148148        return EOK;
    149149}
Note: See TracChangeset for help on using the changeset viewer.