Changeset b7fd2a0 in mainline for uspace/lib/c/generic/arg_parse.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/c/generic/arg_parse.c

    r36f0738 rb7fd2a0  
    6565 *
    6666 */
    67 int arg_parse_int(int argc, char *argv[], int *index, int *value,
     67errno_t arg_parse_int(int argc, char *argv[], int *index, int *value,
    6868    int offset)
    6969{
     
    105105 *
    106106 */
    107 int arg_parse_name_int(int argc, char *argv[], int *index, int *value,
     107errno_t arg_parse_name_int(int argc, char *argv[], int *index, int *value,
    108108    int offset, arg_parser parser)
    109109{
    110110        char *arg;
    111111       
    112         int ret = arg_parse_string(argc, argv, index, &arg, offset);
     112        errno_t ret = arg_parse_string(argc, argv, index, &arg, offset);
    113113        if (ret != EOK)
    114114                return ret;
     
    135135 *
    136136 */
    137 int arg_parse_string(int argc, char **argv, int *index, char **value,
     137errno_t arg_parse_string(int argc, char **argv, int *index, char **value,
    138138    int offset)
    139139{
Note: See TracChangeset for help on using the changeset viewer.