Changeset 4b1c7c6f in mainline for kernel/genarch/src/acpi/acpi.c

Timestamp:

2018-03-16T20:57:16Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

6be2c13

Parents:

973be387

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:51:59)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:57:16)

Message:

Clean up PAGE_* flags.

Remove "nop flags", they are confusing for readers and any benefit they would
gain in self-documentation they lose in being used inconsistently.

Remove "PAGE_READ", the only place it's used meaningfully is the incomplete
RISC-V implementation, and most call sites assume read is implied.

File:

• kernel/genarch/src/acpi/acpi.c (modified) (1 diff)

kernel/genarch/src/acpi/acpi.c

@@ -104 +104 @@
         /* Start with mapping the header only. */
         vhdr = (struct acpi_sdt_header *) km_map((uintptr_t) psdt,
-            sizeof(struct acpi_sdt_header), PAGE_READ | PAGE_NOT_CACHEABLE);
+            sizeof(struct acpi_sdt_header), 0);
 
         /* Now we can map the entire structure. */
         vsdt = (struct acpi_sdt_header *) km_map((uintptr_t) psdt,
-            vhdr->length, PAGE_WRITE | PAGE_NOT_CACHEABLE);
+            vhdr->length, PAGE_WRITE);
 
         // TODO: do not leak vtmp