Changeset f959a20f in mainline for uspace/drv/bus/usb/ohci/endpoint_list.c

Timestamp:

2019-02-01T22:32:38Z (5 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

00b7fc8

Parents:

1a37496

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-01 21:22:39)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2019-02-01 22:32:38)

Message:

Avoid directly using .head/.next/.prev of list_t/link_t

Use existing constructs from <adt/list.h> instead.

File:

• uspace/drv/bus/usb/ohci/endpoint_list.c (modified) (2 diffs)

uspace/drv/bus/usb/ohci/endpoint_list.c

@@ -156 +156 @@
         const char *qpos = NULL;
         ed_t *prev_ed;
+        link_t *prev_link = list_prev(&ep->eplist_link, &instance->endpoint_list);
         /* Remove from the hardware queue */
-        if (list_first(&instance->endpoint_list) == &ep->eplist_link) {
+        if (!prev_link) {
                 /* I'm the first one here */
                 prev_ed = instance->list_head;
@@ -163 +164 @@
         } else {
                 ohci_endpoint_t *prev =
-                    list_get_instance(ep->eplist_link.prev, ohci_endpoint_t, eplist_link);
+                    list_get_instance(prev_link, ohci_endpoint_t, eplist_link);
                 prev_ed = prev->ed;
                 qpos = "NOT FIRST";