Fork us on GitHub Follow us on Facebook Follow us on Twitter

Changeset eac610e in mainline for uspace/lib/c/include/ipc/dev_iface.h


Ignore:
Timestamp:
2010-12-08T23:40:38Z (11 years ago)
Author:
Vojtech Horky <vojtechhorky@…>
Branches:
lfn, master
Children:
07b9203e
Parents:
90fb679
Message:

Fix of several stupid bugs

There were actually four (kind of) bugs fixed in this commit:

  • switched arguments in a function call (really stupid)
  • async_data_read_receive and async_data_read_finalize not paired together
  • reading wrong arguments of a call (the DDF uses IPC_GET_ARG1 for the actual method (as the IPC_GET_METHOD returns interface index) and first argument is in IPC_GET_ARG2)
  • wrong SETUP packet for GET_DESCRIPTOR request


Also, added DEV_IPC_GET_ARG[1-4] for retrieveing arguments in DDF
interfaces in less confusing way (hope so).

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/c/include/ipc/dev_iface.h

    r90fb679 reac610e  
    5454        DEV_IFACE_ID(DEV_FIRST_CUSTOM_METHOD_IDX)
    5555
     56/*
     57 * The first argument is actually method (as the "real" method is used
     58 * for indexing into interfaces.
     59 */
     60
     61#define DEV_IPC_GET_ARG1(call) IPC_GET_ARG2((call))
     62#define DEV_IPC_GET_ARG2(call) IPC_GET_ARG3((call))
     63#define DEV_IPC_GET_ARG3(call) IPC_GET_ARG4((call))
     64#define DEV_IPC_GET_ARG4(call) IPC_GET_ARG5((call))
     65
    5666
    5767#endif
Note: See TracChangeset for help on using the changeset viewer.