Changeset eac610e in mainline for uspace/lib/c/include/ipc/dev_iface.h

Timestamp:

2010-12-08T23:40:38Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

07b9203e

Parents:

90fb679

Message:

Fix of several stupid bugs

There were actually four (kind of) bugs fixed in this commit:

• switched arguments in a function call (really stupid)
• async_data_read_receive and async_data_read_finalize not paired together
• reading wrong arguments of a call (the DDF uses IPC_GET_ARG1 for the actual method (as the IPC_GET_METHOD returns interface index) and first argument is in IPC_GET_ARG2)
• wrong SETUP packet for GET_DESCRIPTOR request

Also, added DEV_IPC_GET_ARG[1-4] for retrieveing arguments in DDF
interfaces in less confusing way (hope so).

File:

• uspace/lib/c/include/ipc/dev_iface.h (modified) (1 diff)

uspace/lib/c/include/ipc/dev_iface.h

@@ -54 +54 @@
         DEV_IFACE_ID(DEV_FIRST_CUSTOM_METHOD_IDX)
 
+/*
+ * The first argument is actually method (as the "real" method is used
+ * for indexing into interfaces.
+ */
+
+#define DEV_IPC_GET_ARG1(call) IPC_GET_ARG2((call))
+#define DEV_IPC_GET_ARG2(call) IPC_GET_ARG3((call))
+#define DEV_IPC_GET_ARG3(call) IPC_GET_ARG4((call))
+#define DEV_IPC_GET_ARG4(call) IPC_GET_ARG5((call))
+
 
 #endif