Changeset e6edc8d1 in mainline for uspace/drv/char/xtkbd/main.c

Timestamp:

2013-07-11T19:13:37Z (11 years ago)

Author:

Manuele Conti <conti.ma@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

67632f7

Parents:

52ff62d3 (diff), 2b3e8840 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge with mainline changes.

File:

• uspace/drv/char/xtkbd/main.c (modified) (1 diff)

uspace/drv/char/xtkbd/main.c

@@ -80 +80 @@
 static int xt_kbd_add(ddf_dev_t *device)
 {
+        int rc;
+
         if (!device)
                 return EINVAL;
 
-#define CHECK_RET_RETURN(ret, message...) \
-if (ret != EOK) { \
-        ddf_msg(LVL_ERROR, message); \
-        return ret; \
-} else (void)0
+        xt_kbd_t *kbd = ddf_dev_data_alloc(device, sizeof(xt_kbd_t));
+        if (kbd == NULL) {
+                ddf_msg(LVL_ERROR, "Failed to allocate XT/KBD driver instance.");
+                return ENOMEM;
+        }
 
-        xt_kbd_t *kbd = ddf_dev_data_alloc(device, sizeof(xt_kbd_t));
-        int ret = (kbd == NULL) ? ENOMEM : EOK;
-        CHECK_RET_RETURN(ret, "Failed to allocate XT/KBD driver instance.");
-
-        ret = xt_kbd_init(kbd, device);
-        CHECK_RET_RETURN(ret,
-            "Failed to initialize XT_KBD driver: %s.", str_error(ret));
+        rc = xt_kbd_init(kbd, device);
+        if (rc != EOK) {
+                ddf_msg(LVL_ERROR, "Failed to initialize XT_KBD driver: %s.",
+                    str_error(rc));
+                return rc;
+        }
 
         ddf_msg(LVL_NOTE, "Controlling '%s' (%" PRIun ").",