Changeset e3f7418 in mainline for uspace/drv/bus/usb/usbhub/port.c

Timestamp:

2011-10-15T13:06:28Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a044f71

Parents:

3958e315 (diff), 065064e6 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

USB improvements.

USB unplug part2; Unplug support in all drivers (except for unused usbmouse driver).
Make descriptor paring work on const pointers.
Fixes several crashes and memory leaks.

File:

• uspace/drv/bus/usb/usbhub/port.c (modified) (1 diff)

uspace/drv/bus/usb/usbhub/port.c

@@ -288 +288 @@
         port->attached_device.fun = NULL;
 
-        ret = usb_hc_unregister_device(&hub->connection,
-            port->attached_device.address);
-        if (ret != EOK) {
-                usb_log_warning("Failed to unregister address of the removed "
-                    "device: %s.\n", str_error(ret));
-        }
+        ret = usb_hc_connection_open(&hub->connection);
+        if (ret == EOK) {
+                ret = usb_hc_unregister_device(&hub->connection,
+                    port->attached_device.address);
+                if (ret != EOK) {
+                        usb_log_warning("Failed to unregister address of the "
+                            "removed device: %s.\n", str_error(ret));
+                }
+                ret = usb_hc_connection_close(&hub->connection);
+                if (ret != EOK) {
+                        usb_log_warning("Failed to close hc connection %s.\n",
+                            str_error(ret));
+                }
+
+        } else {
+                usb_log_warning("Failed to open hc connection %s.\n",
+                    str_error(ret));
+        }
+
         port->attached_device.address = -1;
         fibril_mutex_unlock(&port->mutex);