Changeset d9fae235 in mainline for uspace/srv/hw/cir/fhc/fhc.c

Timestamp:

2010-04-17T01:28:38Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hw/cir/fhc/fhc.c (modified) (2 diffs)

uspace/srv/hw/cir/fhc/fhc.c

@@ -109 +109 @@
 static bool fhc_init(void)
 {
-        ipcarg_t phonead;
+        sysarg_t paddr;
 
-        fhc_uart_size = sysinfo_value("fhc.uart.size");
-        fhc_uart_phys = (void *) sysinfo_value("fhc.uart.physical");
-        
-        if (!fhc_uart_size) {
+        if ((sysinfo_get_value("fhc.uart.physical", &paddr) != EOK)
+            || (sysinfo_get_value("fhc.uart.size", &fhc_uart_size) != EOK)) {
                 printf(NAME ": no FHC UART registers found\n");
                 return false;
         }
-
+        
+        fhc_uart_phys = (void *) paddr;
         fhc_uart_virt = as_get_mappable_page(fhc_uart_size);
         
@@ -132 +131 @@
         printf(NAME ": FHC UART registers at %p, %d bytes\n", fhc_uart_phys,
             fhc_uart_size);
-
+        
         async_set_client_connection(fhc_connection);
+        ipcarg_t phonead;
         ipc_connect_to_me(PHONE_NS, SERVICE_FHC, 0, 0, &phonead);