Changeset d9fae235 in mainline for uspace/srv/hid/kbd/port/niagara.c

Timestamp:

2010-04-17T01:28:38Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hid/kbd/port/niagara.c (modified) (3 diffs)

uspace/srv/hid/kbd/port/niagara.c

@@ -44 +44 @@
 #include <thread.h>
 #include <bool.h>
+#include <errno.h>
 
-#define POLL_INTERVAL           10000
+#define POLL_INTERVAL  10000
 
 /**
@@ -57 +58 @@
  * kernel/arch/sparc64/src/drivers/niagara.c.
  */
-#define INPUT_BUFFER_SIZE       ((PAGE_SIZE) - 2 * 8)
+#define INPUT_BUFFER_SIZE  ((PAGE_SIZE) - 2 * 8)
+
 typedef volatile struct {
         uint64_t write_ptr;
@@ -79 +81 @@
 int kbd_port_init(void)
 {
+        sysarg_t paddr;
+        if (sysinfo_get_value("niagara.inbuf.address", &paddr) != EOK)
+                return -1;
+        
         input_buffer_addr = (uintptr_t) as_get_mappable_page(PAGE_SIZE);
-        int result = physmem_map(
-                (void *) sysinfo_value("niagara.inbuf.address"),
-                (void *) input_buffer_addr,
-                1, AS_AREA_READ | AS_AREA_WRITE);
-
-        if (result != 0) {
+        int rc = physmem_map((void *) paddr, (void *) input_buffer_addr,
+            1, AS_AREA_READ | AS_AREA_WRITE);
+        
+        if (rc != 0) {
                 printf("Niagara: uspace driver couldn't map physical memory: %d\n",
-                        result);
-        }
-
-        input_buffer = (input_buffer_t) input_buffer_addr;
-
-        thread_id_t tid;
-        int rc;
-
-        rc = thread_create(niagara_thread_impl, NULL, "kbd_poll", &tid);
-        if (rc != 0) {
+                    rc);
                 return rc;
         }
+        
+        input_buffer = (input_buffer_t) input_buffer_addr;
+        
+        thread_id_t tid;
+        rc = thread_create(niagara_thread_impl, NULL, "kbd_poll", &tid);
+        if (rc != 0)
+                return rc;
+        
         return 0;
 }