Changeset d9fae235 in mainline for uspace/srv/hid/fb/ega.c

Timestamp:

2010-04-17T01:28:38Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9d6bfa5

Parents:

9256ad29

Message:

sysinfo overhaul

• cleanup (nicer data structures, use of SLAB allocator)
• add support for storing arbitrary binary data
• properly reimplement non-constant values (generated by functions)
• add support for non-constant subtrees (generated by functions)
• syscall ABI change, libc API change
• reflect changes in user code

libc: task_spawn() can now return error code

• reflect change in user code, print error strings after failed task_spawn()

uspace cleanup

• more use of string and other constants
• more use of str_error()
• unify error reporting in init

File:

• uspace/srv/hid/fb/ega.c (modified) (1 diff)

uspace/srv/hid/fb/ega.c

@@ -415 +415 @@
         void *ega_ph_addr;
         size_t sz;
-
-        ega_ph_addr = (void *) sysinfo_value("fb.address.physical");
-        scr_width = sysinfo_value("fb.width");
-        scr_height = sysinfo_value("fb.height");
-
-        if (sysinfo_value("fb.blinking")) {
+        
+        sysarg_t paddr;
+        if (sysinfo_get_value("fb.address.physical", &paddr) != EOK)
+                return -1;
+        
+        sysarg_t width;
+        if (sysinfo_get_value("fb.width", &width) != EOK)
+                return -1;
+        
+        sysarg_t height;
+        if (sysinfo_get_value("fb.width", &height) != EOK)
+                return -1;
+        
+        sysarg_t blinking;
+        if (sysinfo_get_value("fb.blinking", &blinking) != EOK)
+                blinking = false;
+        
+        ega_ph_addr = (void *) paddr;
+        scr_width = width;
+        scr_height = height;
+        if (blinking) {
                 ega_normal_color &= 0x77;
                 ega_inverted_color &= 0x77;
         }
-
+        
         style = NORMAL_COLOR;
-
+        
         iospace_enable(task_get_id(), (void *) EGA_IO_BASE, 2);
-
+        
         sz = scr_width * scr_height * 2;
         scr_addr = as_get_mappable_page(sz);
-
+        
         if (physmem_map(ega_ph_addr, scr_addr, ALIGN_UP(sz, PAGE_SIZE) >>
             PAGE_WIDTH, AS_AREA_READ | AS_AREA_WRITE) != 0)