Changeset bc216a0 in mainline for uspace/srv/vfs/vfs_node.c

Timestamp:

2012-08-07T22:13:44Z (12 years ago)

Author:

Adam Hraska <adam.hraska+hos@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

da68871a

Parents:

b17518e

Message:

Refactored any users of hash_table to use opaque void* keys instead of the cumbersome unsigned long[] keys. Switched from the ad hoc computations of hashes of multiple values to hash_combine().

File:

• uspace/srv/vfs/vfs_node.c (modified) (11 diffs)

uspace/srv/vfs/vfs_node.c

@@ -41 +41 @@
 #include <fibril_synch.h>
 #include <adt/hash_table.h>
+#include <adt/hash.h>
 #include <assert.h>
 #include <async.h>
@@ -58 +59 @@
 #define KEY_INDEX       2
 
-static size_t nodes_key_hash(unsigned long []);
-static size_t nodes_hash(const link_t *);
-static bool nodes_match(unsigned long [], size_t, const link_t *);
+static size_t nodes_key_hash(void *);
+static size_t nodes_hash(const ht_link_t *);
+static bool nodes_key_equal(void *, const ht_link_t *);
+static vfs_triplet_t node_triplet(vfs_node_t *node);
 
 /** VFS node hash table operations. */
@@ -66 +68 @@
         .hash = nodes_hash,
         .key_hash = nodes_key_hash,
-        .match = nodes_match,
+        .key_equal = nodes_key_equal,
         .equal = 0,
         .remove_callback = 0,
@@ -77 +79 @@
 bool vfs_nodes_init(void)
 {
-        return hash_table_create(&nodes, 0, 3, &nodes_ops);
+        return hash_table_create(&nodes, 0, 0, &nodes_ops);
 }
 
@@ -116 +118 @@
                  */
                 
-                unsigned long key[] = {
-                        [KEY_FS_HANDLE] = node->fs_handle,
-                        [KEY_DEV_HANDLE] = node->service_id,
-                        [KEY_INDEX] = node->index
-                };
-                
-                hash_table_remove(&nodes, key, 3);
+                hash_table_remove_item(&nodes, &node->nh_link);
                 free_vfs_node = true;
                 
@@ -160 +156 @@
 {
         fibril_mutex_lock(&nodes_mutex);
-        unsigned long key[] = {
-                [KEY_FS_HANDLE] = node->fs_handle,
-                [KEY_DEV_HANDLE] = node->service_id,
-                [KEY_INDEX] = node->index
-        };
-        hash_table_remove(&nodes, key, 3);
+        hash_table_remove_item(&nodes, &node->nh_link);
         fibril_mutex_unlock(&nodes_mutex);
         free(node);
@@ -184 +175 @@
 vfs_node_t *vfs_node_get(vfs_lookup_res_t *result)
 {
-        unsigned long key[] = {
-                [KEY_FS_HANDLE] = result->triplet.fs_handle,
-                [KEY_DEV_HANDLE] = result->triplet.service_id,
-                [KEY_INDEX] = result->triplet.index
-        };
-        link_t *tmp;
         vfs_node_t *node;
 
         fibril_mutex_lock(&nodes_mutex);
-        tmp = hash_table_find(&nodes, key);
+        ht_link_t *tmp = hash_table_find(&nodes, &result->triplet);
         if (!tmp) {
                 node = (vfs_node_t *) malloc(sizeof(vfs_node_t));
@@ -207 +192 @@
                 node->lnkcnt = result->lnkcnt;
                 node->type = result->type;
-                link_initialize(&node->nh_link);
                 fibril_rwlock_initialize(&node->contents_rwlock);
                 hash_table_insert(&nodes, &node->nh_link);
         } else {
-                node = hash_table_get_instance(tmp, vfs_node_t, nh_link);
+                node = hash_table_get_inst(tmp, vfs_node_t, nh_link);
                 if (node->type == VFS_NODE_UNKNOWN &&
                     result->type != VFS_NODE_UNKNOWN) {
@@ -242 +226 @@
 }
 
-size_t nodes_key_hash(unsigned long key[])
-{
-        /* Combine into a hash like they do in Effective Java, 2nd edition. */
-        size_t hash = 17;
-        hash = 37 * hash + key[KEY_FS_HANDLE];
-        hash = 37 * hash + key[KEY_DEV_HANDLE];
-        hash = 37 * hash + key[KEY_INDEX];
-        return hash;
-}
-
-size_t nodes_hash(const link_t *item)
-{
-        vfs_node_t *node = hash_table_get_instance(item, vfs_node_t, nh_link);
-        
-        unsigned long key[] = {
-                [KEY_FS_HANDLE] = node->fs_handle,
-                [KEY_DEV_HANDLE] = node->service_id,
-                [KEY_INDEX] = node->index
-        };
-        
-        return nodes_key_hash(key);
-}
-
-
-bool nodes_match(unsigned long key[], size_t keys, const link_t *item)
-{
-        vfs_node_t *node = hash_table_get_instance(item, vfs_node_t, nh_link);
-        return (node->fs_handle == (fs_handle_t) key[KEY_FS_HANDLE]) &&
-            (node->service_id == key[KEY_DEV_HANDLE]) &&
-            (node->index == key[KEY_INDEX]);
-}
-
-
 struct refcnt_data {
         /** Sum of all reference counts for this file system instance. */
@@ -282 +233 @@
 };
 
-static bool refcnt_visitor(link_t *item, void *arg)
-{
-        vfs_node_t *node = hash_table_get_instance(item, vfs_node_t, nh_link);
+static bool refcnt_visitor(ht_link_t *item, void *arg)
+{
+        vfs_node_t *node = hash_table_get_inst(item, vfs_node_t, nh_link);
         struct refcnt_data *rd = (void *) arg;
 
@@ -332 +283 @@
 }
 
+
+static size_t nodes_key_hash(void *key)
+{
+        vfs_triplet_t *tri = key;
+        size_t hash = hash_combine(tri->fs_handle, tri->index);
+        return hash_combine(hash, tri->service_id);
+}
+
+static size_t nodes_hash(const ht_link_t *item)
+{
+        vfs_node_t *node = hash_table_get_inst(item, vfs_node_t, nh_link);
+        vfs_triplet_t tri = node_triplet(node);
+        return nodes_key_hash(&tri);
+}
+
+static bool nodes_key_equal(void *key, const ht_link_t *item)
+{
+        vfs_triplet_t *tri = key;
+        vfs_node_t *node = hash_table_get_inst(item, vfs_node_t, nh_link);
+        return node->fs_handle == tri->fs_handle 
+                && node->service_id == tri->service_id
+                && node->index == tri->index;
+}
+
+static inline vfs_triplet_t node_triplet(vfs_node_t *node)
+{
+        vfs_triplet_t tri = {
+                .fs_handle = node->fs_handle,
+                .service_id = node->service_id,
+                .index = node->index
+        };
+        
+        return tri;
+}
+
 /**
  * @}