Changeset bc216a0 in mainline for uspace/lib/block/libblock.c

Timestamp:

2012-08-07T22:13:44Z (12 years ago)

Author:

Adam Hraska <adam.hraska+hos@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

da68871a

Parents:

b17518e

Message:

Refactored any users of hash_table to use opaque void* keys instead of the cumbersome unsigned long[] keys. Switched from the ad hoc computations of hashes of multiple values to hash_combine().

File:

• uspace/lib/block/libblock.c (modified) (11 diffs)

uspace/lib/block/libblock.c

@@ -254 +254 @@
 }
 
-static size_t cache_key_hash(unsigned long *key)
-{
-        /* As recommended by Effective Java, 2nd Edition. */
-        size_t hash = 17;
-        hash = 31 * hash + key[1];
-        hash = 31 * hash + key[0];
-        return hash;
-}
-
-static size_t cache_hash(const link_t *item)
-{
-        block_t *b = hash_table_get_instance(item, block_t, hash_link);
-        unsigned long key[] = {
-                LOWER32(b->lba),
-                UPPER32(b->lba)
-        };
-        
-        return cache_key_hash(key);
-}
-
-static bool cache_match(unsigned long *key, size_t keys, const link_t *item)
-{
-        block_t *b = hash_table_get_instance(item, block_t, hash_link);
-        return b->lba == MERGE_LOUP32(key[0], key[1]);
+static size_t cache_key_hash(void *key)
+{
+        aoff64_t *lba = (aoff64_t*)key;
+        return *lba;
+}
+
+static size_t cache_hash(const ht_link_t *item)
+{
+        block_t *b = hash_table_get_inst(item, block_t, hash_link);
+        return b->lba;
+}
+
+static bool cache_key_equal(void *key, const ht_link_t *item)
+{
+        aoff64_t *lba = (aoff64_t*)key;
+        block_t *b = hash_table_get_inst(item, block_t, hash_link);
+        return b->lba == *lba;
 }
 
@@ -284 +277 @@
         .hash = cache_hash,
         .key_hash = cache_key_hash,
-        .match = cache_match,
+        .key_equal = cache_key_equal,
         .equal = 0,
         .remove_callback = 0
@@ -317 +310 @@
         cache->blocks_cluster = cache->lblock_size / devcon->pblock_size;
 
-        if (!hash_table_create(&cache->block_hash, 0, 2, &cache_ops)) {
+        if (!hash_table_create(&cache->block_hash, 0, 0, &cache_ops)) {
                 free(cache);
                 return ENOMEM;
@@ -355 +348 @@
                 }
 
-                unsigned long key[2] = {
-                        LOWER32(b->lba),
-                        UPPER32(b->lba)
-                };
-                hash_table_remove(&cache->block_hash, key, 2);
+                hash_table_remove_item(&cache->block_hash, &b->hash_link);
                 
                 free(b->data);
@@ -391 +380 @@
         fibril_rwlock_initialize(&b->contents_lock);
         link_initialize(&b->free_link);
-        link_initialize(&b->hash_link);
 }
 
@@ -411 +399 @@
         cache_t *cache;
         block_t *b;
-        link_t *l;
-        unsigned long key[2] = {
-                LOWER32(ba),
-                UPPER32(ba)
-        };
+        link_t *link;
 
         int rc;
@@ -431 +415 @@
 
         fibril_mutex_lock(&cache->lock);
-        l = hash_table_find(&cache->block_hash, key);
-        if (l) {
+        ht_link_t *hlink = hash_table_find(&cache->block_hash, &ba);
+        if (hlink) {
 found:
                 /*
                  * We found the block in the cache.
                  */
-                b = hash_table_get_instance(l, block_t, hash_link);
+                b = hash_table_get_inst(hlink, block_t, hash_link);
                 fibril_mutex_lock(&b->lock);
                 if (b->refcnt++ == 0)
@@ -475 +459 @@
                                 goto out;
                         }
-                        l = list_first(&cache->free_list);
-                        b = list_get_instance(l, block_t, free_link);
+                        link = list_first(&cache->free_list);
+                        b = list_get_instance(link, block_t, free_link);
 
                         fibril_mutex_lock(&b->lock);
@@ -516 +500 @@
                                         goto retry;
                                 }
-                                l = hash_table_find(&cache->block_hash, key);
-                                if (l) {
+                                hlink = hash_table_find(&cache->block_hash, &ba);
+                                if (hlink) {
                                         /*
                                          * Someone else must have already
@@ -539 +523 @@
                          */
                         list_remove(&b->free_link);
-                        unsigned long temp_key[2] = {
-                                LOWER32(b->lba),
-                                UPPER32(b->lba)
-                        };
-                        hash_table_remove(&cache->block_hash, temp_key, 2);
+                        hash_table_remove_item(&cache->block_hash, &b->hash_link);
                 }
 
@@ -663 +643 @@
                          * Take the block out of the cache and free it.
                          */
-                        unsigned long key[2] = {
-                                LOWER32(block->lba),
-                                UPPER32(block->lba)
-                        };
-                        hash_table_remove(&cache->block_hash, key, 2);
+                        hash_table_remove_item(&cache->block_hash, &block->hash_link);
                         fibril_mutex_unlock(&block->lock);
                         free(block->data);