Changeset b7fd2a0 in mainline for uspace/srv/volsrv/mkfs.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/volsrv/mkfs.c (modified) (3 diffs)

uspace/srv/volsrv/mkfs.c

@@ -47 +47 @@
 #include "mkfs.h"
 
-static int cmd_runl(const char *path, ...)
+static errno_t cmd_runl(const char *path, ...)
 {
         va_list ap;
@@ -63 +63 @@
         task_id_t id;
         task_wait_t wait;
-        int rc = task_spawn(&id, &wait, path, cnt, ap);
+        errno_t rc = task_spawn(&id, &wait, path, cnt, ap);
         va_end(ap);
 
@@ -102 +102 @@
 
 
-int volsrv_part_mkfs(service_id_t sid, vol_fstype_t fstype, const char *label)
+errno_t volsrv_part_mkfs(service_id_t sid, vol_fstype_t fstype, const char *label)
 {
         const char *cmd;
         char *svc_name;
-        int rc;
+        errno_t rc;
 
         cmd = NULL;