Changeset b7fd2a0 in mainline for uspace/srv/net/nconfsrv/iplink.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/nconfsrv/iplink.c (modified) (5 diffs)

uspace/srv/net/nconfsrv/iplink.c

@@ -49 +49 @@
 #include "nconfsrv.h"
 
-static int ncs_link_add(service_id_t);
+static errno_t ncs_link_add(service_id_t);
 
 static LIST_INITIALIZE(ncs_links);
 static FIBRIL_MUTEX_INITIALIZE(ncs_links_lock);
 
-static int ncs_link_check_new(void)
+static errno_t ncs_link_check_new(void)
 {
         bool already_known;
@@ -60 +60 @@
         service_id_t *svcs;
         size_t count, i;
-        int rc;
+        errno_t rc;
 
         fibril_mutex_lock(&ncs_links_lock);
@@ -124 +124 @@
 }
 
-static int ncs_link_add(service_id_t sid)
+static errno_t ncs_link_add(service_id_t sid)
 {
         ncs_link_t *nlink;
-        int rc;
+        errno_t rc;
 
         assert(fibril_mutex_is_locked(&ncs_links_lock));
@@ -175 +175 @@
 }
 
-int ncs_link_discovery_start(void)
-{
-        int rc;
+errno_t ncs_link_discovery_start(void)
+{
+        errno_t rc;
 
         rc = loc_register_cat_change_cb(ncs_link_cat_change_cb);
@@ -205 +205 @@
 
 /** Get IDs of all links. */
-int ncs_link_get_id_list(sysarg_t **rid_list, size_t *rcount)
+errno_t ncs_link_get_id_list(sysarg_t **rid_list, size_t *rcount)
 {
         sysarg_t *id_list;