Changeset b7fd2a0 in mainline for uspace/srv/net/dnsrsrv/dnsrsrv.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/net/dnsrsrv/dnsrsrv.c (modified) (5 diffs)

uspace/srv/net/dnsrsrv/dnsrsrv.c

@@ -54 +54 @@
 static void dnsr_client_conn(ipc_callid_t, ipc_call_t *, void *);
 
-static int dnsr_init(void)
-{
-        int rc;
+static errno_t dnsr_init(void)
+{
+        errno_t rc;
         log_msg(LOG_DEFAULT, LVL_DEBUG, "dnsr_init()");
 
@@ -93 +93 @@
         
         char *name;
-        int rc = async_data_write_accept((void **) &name, true, 0,
+        errno_t rc = async_data_write_accept((void **) &name, true, 0,
             DNS_NAME_MAX_SIZE, 0, NULL);
         if (rc != EOK) {
@@ -171 +171 @@
         // FIXME locking
         
-        int rc = async_data_read_finalize(callid, &dns_server_addr, size);
+        errno_t rc = async_data_read_finalize(callid, &dns_server_addr, size);
         if (rc != EOK)
                 async_answer_0(callid, rc);
@@ -199 +199 @@
         // FIXME locking
         
-        int rc = async_data_write_finalize(callid, &dns_server_addr, size);
+        errno_t rc = async_data_write_finalize(callid, &dns_server_addr, size);
         if (rc != EOK) {
                 async_answer_0(callid, rc);
@@ -246 +246 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
 
         printf("%s: DNS Resolution Service\n", NAME);