Changeset b7fd2a0 in mainline for uspace/srv/hid/rfb/main.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/hid/rfb/main.c (modified) (3 diffs)

uspace/srv/hid/rfb/main.c

@@ -52 +52 @@
 static rfb_t rfb;
 
-static int rfb_claim(visualizer_t *vs)
-{
-        return EOK;
-}
-
-static int rfb_yield(visualizer_t *vs)
-{
-        return EOK;
-}
-
-static int rfb_suspend(visualizer_t *vs)
-{
-        return EOK;
-}
-
-static int rfb_wakeup(visualizer_t *vs)
-{
-        return EOK;
-}
-
-static int rfb_handle_damage_pixels(visualizer_t *vs,
+static errno_t rfb_claim(visualizer_t *vs)
+{
+        return EOK;
+}
+
+static errno_t rfb_yield(visualizer_t *vs)
+{
+        return EOK;
+}
+
+static errno_t rfb_suspend(visualizer_t *vs)
+{
+        return EOK;
+}
+
+static errno_t rfb_wakeup(visualizer_t *vs)
+{
+        return EOK;
+}
+
+static errno_t rfb_handle_damage_pixels(visualizer_t *vs,
     sysarg_t x0, sysarg_t y0, sysarg_t width, sysarg_t height,
     sysarg_t x_offset, sysarg_t y_offset)
@@ -126 +126 @@
 }
 
-static int rfb_change_mode(visualizer_t *vs, vslmode_t new_mode)
+static errno_t rfb_change_mode(visualizer_t *vs, vslmode_t new_mode)
 {
         return EOK;
@@ -217 +217 @@
         async_set_fallback_port_handler(client_connection, NULL);
 
-        int rc = loc_server_register(NAME);
+        errno_t rc = loc_server_register(NAME);
         if (rc != EOK) {
                 printf("%s: Unable to register server.\n", NAME);