Changeset b7fd2a0 in mainline for uspace/srv/hid/input/input.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/srv/hid/input/input.c (modified) (13 diffs)

uspace/srv/hid/input/input.c

@@ -473 +473 @@
         kdev->ctl_ops = &kbdev_ctl;
         
-        int rc = loc_service_get_name(service_id, &kdev->svc_name);
+        errno_t rc = loc_service_get_name(service_id, &kdev->svc_name);
         if (rc != EOK) {
                 kdev->svc_name = NULL;
@@ -510 +510 @@
         mdev->proto_ops = &mousedev_proto;
         
-        int rc = loc_service_get_name(service_id, &mdev->svc_name);
+        errno_t rc = loc_service_get_name(service_id, &mdev->svc_name);
         if (rc != EOK) {
                 mdev->svc_name = NULL;
@@ -530 +530 @@
 }
 
-static int serial_consumer(void *arg)
+static errno_t serial_consumer(void *arg)
 {
         serial_dev_t *sdev = (serial_dev_t *) arg;
@@ -554 +554 @@
 {
         bool match = false;
-        int rc;
+        errno_t rc;
 
         serial_dev_t *sdev = serial_dev_new();
@@ -633 +633 @@
 }
 
-static int dev_check_new_kbdevs(void)
+static errno_t dev_check_new_kbdevs(void)
 {
         category_id_t keyboard_cat;
@@ -639 +639 @@
         size_t count, i;
         bool already_known;
-        int rc;
+        errno_t rc;
         
         rc = loc_category_get_id("keyboard", &keyboard_cat, IPC_FLAG_BLOCKING);
@@ -684 +684 @@
 }
 
-static int dev_check_new_mousedevs(void)
+static errno_t dev_check_new_mousedevs(void)
 {
         category_id_t mouse_cat;
@@ -690 +690 @@
         size_t count, i;
         bool already_known;
-        int rc;
+        errno_t rc;
         
         rc = loc_category_get_id("mouse", &mouse_cat, IPC_FLAG_BLOCKING);
@@ -735 +735 @@
 }
 
-static int dev_check_new_serialdevs(void)
+static errno_t dev_check_new_serialdevs(void)
 {
         category_id_t serial_cat;
@@ -741 +741 @@
         size_t count, i;
         bool already_known;
-        int rc;
+        errno_t rc;
         
         rc = loc_category_get_id("serial", &serial_cat, IPC_FLAG_BLOCKING);
@@ -786 +786 @@
 }
 
-static int dev_check_new(void)
-{
-        int rc;
+static errno_t dev_check_new(void)
+{
+        errno_t rc;
         
         fibril_mutex_lock(&discovery_lock);
@@ -823 +823 @@
 
 /** Start listening for new devices. */
-static int input_start_dev_discovery(void)
-{
-        int rc = loc_register_cat_change_cb(cat_change_cb);
+static errno_t input_start_dev_discovery(void)
+{
+        errno_t rc = loc_register_cat_change_cb(cat_change_cb);
         if (rc != EOK) {
                 printf("%s: Failed registering callback for device discovery: "
@@ -842 +842 @@
 int main(int argc, char **argv)
 {
-        int rc;
+        errno_t rc;
 
         if (argc < 2) {