Changeset b7fd2a0 in mainline for uspace/lib/uri/uri.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (6 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/uri/uri.c

    r36f0738 rb7fd2a0  
    143143 * @return EOK on success
    144144 */
    145 int uri_scheme_parse(const char *str, const char **endptr)
     145errno_t uri_scheme_parse(const char *str, const char **endptr)
    146146{
    147147        if (*str == 0) {
     
    175175}
    176176
    177 int uri_percent_parse(const char *str, const char **endptr,
     177errno_t uri_percent_parse(const char *str, const char **endptr,
    178178    uint8_t *decoded)
    179179{
     
    186186       
    187187        if (decoded != NULL) {
    188                 int rc = str_uint8_t(str + 1, NULL, 16, true, decoded);
     188                errno_t rc = str_uint8_t(str + 1, NULL, 16, true, decoded);
    189189                if (rc != EOK)
    190190                        return rc;
     
    195195}
    196196
    197 int uri_user_info_parse(const char *str, const char **endptr)
     197errno_t uri_user_info_parse(const char *str, const char **endptr)
    198198{
    199199        while (*str != 0) {
     
    201201                if (*str == 0)
    202202                        break;
    203                 int rc = uri_percent_parse(str, &str, NULL);
     203                errno_t rc = uri_percent_parse(str, &str, NULL);
    204204                if (rc != EOK) {
    205205                        *endptr = str;
     
    220220}
    221221
    222 int uri_port_parse(const char *str, const char **endptr)
     222errno_t uri_port_parse(const char *str, const char **endptr)
    223223{
    224224        if (*str == 0)
Note: See TracChangeset for help on using the changeset viewer.