Changeset b7fd2a0 in mainline for uspace/lib/drv/include/usbhid_iface.h

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/usbhid_iface.h (modified) (3 diffs)

uspace/lib/drv/include/usbhid_iface.h

@@ -39 +39 @@
 #include "ddf/driver.h"
 
-extern int usbhid_dev_get_event_length(async_sess_t *, size_t *);
-extern int usbhid_dev_get_event(async_sess_t *, uint8_t *, size_t, size_t *,
+extern errno_t usbhid_dev_get_event_length(async_sess_t *, size_t *);
+extern errno_t usbhid_dev_get_event(async_sess_t *, uint8_t *, size_t, size_t *,
     int *, unsigned int);
-extern int usbhid_dev_get_report_descriptor_length(async_sess_t *, size_t *);
-extern int usbhid_dev_get_report_descriptor(async_sess_t *, uint8_t *, size_t,
+extern errno_t usbhid_dev_get_report_descriptor_length(async_sess_t *, size_t *);
+extern errno_t usbhid_dev_get_report_descriptor(async_sess_t *, uint8_t *, size_t,
     size_t *);
 
@@ -63 +63 @@
          * @return Error code.
          */
-        int (*get_event)(ddf_fun_t *fun, uint8_t *buffer, size_t size,
+        errno_t (*get_event)(ddf_fun_t *fun, uint8_t *buffer, size_t size,
             size_t *act_size, int *event_nr, unsigned int flags);
         
@@ -81 +81 @@
          * @return Error code.
          */
-        int (*get_report_descriptor)(ddf_fun_t *fun, uint8_t *desc, 
+        errno_t (*get_report_descriptor)(ddf_fun_t *fun, uint8_t *desc, 
             size_t size, size_t *act_size);
 } usbhid_iface_t;