Changeset b7fd2a0 in mainline for uspace/lib/c/generic/as.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/as.c (modified) (4 diffs)

uspace/lib/c/generic/as.c

@@ -74 +74 @@
  *
  */
-int as_area_resize(void *address, size_t size, unsigned int flags)
+errno_t as_area_resize(void *address, size_t size, unsigned int flags)
 {
-        return (int) __SYSCALL3(SYS_AS_AREA_RESIZE, (sysarg_t) address,
+        return (errno_t) __SYSCALL3(SYS_AS_AREA_RESIZE, (sysarg_t) address,
             (sysarg_t) size, (sysarg_t) flags);
 }
@@ -88 +88 @@
  *
  */
-int as_area_destroy(void *address)
+errno_t as_area_destroy(void *address)
 {
-        return (int) __SYSCALL1(SYS_AS_AREA_DESTROY, (sysarg_t) address);
+        return (errno_t) __SYSCALL1(SYS_AS_AREA_DESTROY, (sysarg_t) address);
 }
 
@@ -102 +102 @@
  *
  */
-int as_area_change_flags(void *address, unsigned int flags)
+errno_t as_area_change_flags(void *address, unsigned int flags)
 {
-        return (int) __SYSCALL2(SYS_AS_AREA_CHANGE_FLAGS, (sysarg_t) address,
+        return (errno_t) __SYSCALL2(SYS_AS_AREA_CHANGE_FLAGS, (sysarg_t) address,
             (sysarg_t) flags);
 }
@@ -117 +117 @@
  *
  */
-int as_get_physical_mapping(const void *virt, uintptr_t *phys)
+errno_t as_get_physical_mapping(const void *virt, uintptr_t *phys)
 {
-        return (int) __SYSCALL2(SYS_PAGE_FIND_MAPPING, (sysarg_t) virt,
+        return (errno_t) __SYSCALL2(SYS_PAGE_FIND_MAPPING, (sysarg_t) virt,
             (sysarg_t) phys);
 }