Changeset b7fd2a0 in mainline for uspace/drv/platform/icp/icp.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/platform/icp/icp.c (modified) (9 diffs)

uspace/drv/platform/icp/icp.c

@@ -62 +62 @@
 } icp_fun_t;
 
-static int icp_dev_add(ddf_dev_t *dev);
+static errno_t icp_dev_add(ddf_dev_t *dev);
 
 static driver_ops_t icp_ops = {
@@ -178 +178 @@
 }
 
-static int icp_fun_enable_interrupt(ddf_fun_t *fnode, int irq)
+static errno_t icp_fun_enable_interrupt(ddf_fun_t *fnode, int irq)
 {
         icp_fun_t *fun = icp_fun(fnode);
@@ -188 +188 @@
 }
 
-static int icp_fun_disable_interrupt(ddf_fun_t *fnode, int irq)
+static errno_t icp_fun_disable_interrupt(ddf_fun_t *fnode, int irq)
 {
         icp_fun_t *fun = icp_fun(fnode);
@@ -198 +198 @@
 }
 
-static int icp_fun_clear_interrupt(ddf_fun_t *fnode, int irq)
+static errno_t icp_fun_clear_interrupt(ddf_fun_t *fnode, int irq)
 {
         icp_fun_t *fun = icp_fun(fnode);
@@ -231 +231 @@
 };
 
-static int icp_add_fun(ddf_dev_t *dev, const char *name, const char *str_match_id,
+static errno_t icp_add_fun(ddf_dev_t *dev, const char *name, const char *str_match_id,
     icp_fun_t *fun_proto)
 {
@@ -237 +237 @@
 
         ddf_fun_t *fnode = NULL;
-        int rc;
+        errno_t rc;
 
         /* Create new device. */
@@ -275 +275 @@
 }
 
-static int icp_add_functions(ddf_dev_t *dev)
-{
-        int rc;
+static errno_t icp_add_functions(ddf_dev_t *dev)
+{
+        errno_t rc;
 
         rc = icp_add_fun(dev, "intctl", "integratorcp/intctl",
@@ -296 +296 @@
 
 /** Add device. */
-static int icp_dev_add(ddf_dev_t *dev)
+static errno_t icp_dev_add(ddf_dev_t *dev)
 {
         ddf_msg(LVL_NOTE, "icp_dev_add, device handle = %d",
@@ -311 +311 @@
 int main(int argc, char *argv[])
 {
-        int rc;
+        errno_t rc;
 
         printf(NAME ": HelenOS IntegratorCP platform driver\n");