Changeset b7fd2a0 in mainline for uspace/app/sysinst/futil.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/sysinst/futil.c (modified) (4 diffs)

uspace/app/sysinst/futil.c

@@ -54 +54 @@
  * @return EOK on success, EIO on I/O error
  */
-int futil_copy_file(const char *srcp, const char *destp)
+errno_t futil_copy_file(const char *srcp, const char *destp)
 {
         int sf, df;
         size_t nr, nw;
-        int rc;
+        errno_t rc;
         aoff64_t posr = 0, posw = 0;
 
@@ -104 +104 @@
  * @return EOK on success, ENOMEM if out of memory, EIO on I/O error
  */
-int futil_rcopy_contents(const char *srcdir, const char *destdir)
+errno_t futil_rcopy_contents(const char *srcdir, const char *destdir)
 {
         DIR *dir;
@@ -110 +110 @@
         struct stat s;
         char *srcp, *destp;
-        int rc;
+        errno_t rc;
 
         dir = opendir(srcdir);
@@ -158 +158 @@
  *         I/O error, ENOMEM if out of memory
  */
-int futil_get_file(const char *srcp, void **rdata, size_t *rsize)
+errno_t futil_get_file(const char *srcp, void **rdata, size_t *rsize)
 {
         int sf;
         size_t nr;
-        int rc;
+        errno_t rc;
         size_t fsize;
         char *data;