Changeset b7fd2a0 in mainline for uspace/app/getterm/getterm.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/getterm/getterm.c (modified) (3 diffs)

uspace/app/getterm/getterm.c

@@ -66 +66 @@
         
         int oldfd;
-        int rc = vfs_lookup_open(path, WALK_REGULAR, mode, &oldfd);
+        errno_t rc = vfs_lookup_open(path, WALK_REGULAR, mode, &oldfd);
         if (rc != EOK)
                 return;
@@ -133 +133 @@
                 /* Wait for the terminal service to be ready */
                 service_id_t service_id;
-                int rc = loc_service_get_id(term, &service_id, IPC_FLAG_BLOCKING);
+                errno_t rc = loc_service_get_id(term, &service_id, IPC_FLAG_BLOCKING);
                 if (rc != EOK) {
                         printf("%s: Error waiting on %s (%s)\n", APP_NAME, term,
@@ -170 +170 @@
         task_wait_t twait;
         
-        int rc = task_spawnv(&id, &twait, cmd, (const char * const *) args);
+        errno_t rc = task_spawnv(&id, &twait, cmd, (const char * const *) args);
         if (rc != EOK) {
                 printf("%s: Error spawning %s (%s)\n", APP_NAME, cmd,