Changeset b7fd2a0 in mainline for uspace/app/bdsh/cmds/modules/cp/cp.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/bdsh/cmds/modules/cp/cp.c (modified) (4 diffs)

uspace/app/bdsh/cmds/modules/cp/cp.c

@@ -82 +82 @@
         struct stat s;
 
-        int r = vfs_stat_path(path, &s);
+        errno_t r = vfs_stat_path(path, &s);
 
         if (r != EOK)
@@ -176 +176 @@
 }
 
-static int do_copy(const char *src, const char *dest,
+static errno_t do_copy(const char *src, const char *dest,
     size_t blen, int vb, int recursive, int force, int interactive)
 {
-        int rc = EOK;
+        errno_t rc = EOK;
         char dest_path[PATH_MAX];
         char src_path[PATH_MAX];
@@ -388 +388 @@
         int fd1, fd2;
         size_t rbytes, wbytes;
-        int rc;
+        errno_t rc;
         off64_t total;
         char *buff = NULL;
@@ -479 +479 @@
         int force = 0, interactive = 0;
         int c, opt_ind;
-        int ret;
+        errno_t ret;
 
         con = console_init(stdin, stdout);