Changeset b7fd2a0 in mainline for kernel/generic/src/ipc/ops/datawrite.c

Timestamp:

2018-01-13T03:10:29Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/ipc/ops/datawrite.c (modified) (4 diffs)

kernel/generic/src/ipc/ops/datawrite.c

@@ -41 +41 @@
 #include <config.h>
 
-static int request_preprocess(call_t *call, phone_t *phone)
+static errno_t request_preprocess(call_t *call, phone_t *phone)
 {
         uintptr_t src = IPC_GET_ARG1(call->data);
@@ -57 +57 @@
 
         call->buffer = (uint8_t *) malloc(size, 0);
-        int rc = copy_from_uspace(call->buffer, (void *) src, size);
+        errno_t rc = copy_from_uspace(call->buffer, (void *) src, size);
         if (rc != 0) {
                 /*
@@ -69 +69 @@
 }
 
-static int answer_preprocess(call_t *answer, ipc_data_t *olddata)
+static errno_t answer_preprocess(call_t *answer, ipc_data_t *olddata)
 {
         assert(answer->buffer);
@@ -80 +80 @@
                         
                 if (size <= max_size) {
-                        int rc = copy_to_uspace((void *) dst,
+                        errno_t rc = copy_to_uspace((void *) dst,
                             answer->buffer, size);
                         if (rc)