Changeset ae5aa90 in mainline for kernel/generic/src/udebug/udebug.c

Timestamp:

2009-05-14T21:29:00Z (15 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ba6262

Parents:

8ebc8bf4

Message:

Clean up various log messages, mostly udebug.

File:

• kernel/generic/src/udebug/udebug.c (modified) (9 diffs)

kernel/generic/src/udebug/udebug.c

@@ -272 +272 @@
         }
 
-        //printf("udebug_syscall_event\n");
+        /* Fill in the GO response. */
         call = THREAD->udebug.go_call;
         THREAD->udebug.go_call = NULL;
@@ -280 +280 @@
         IPC_SET_ARG2(call->data, id);
         IPC_SET_ARG3(call->data, rc);
-        //printf("udebug_syscall_event/ipc_answer\n");
 
         THREAD->udebug.syscall_args[0] = a1;
@@ -330 +329 @@
         thread_attach(t, ta);
 
-        LOG("udebug_thread_b_event\n");
-        LOG("- check state\n");
+        LOG("Check state");
 
         /* Must only generate events when in debugging session */
         if (THREAD->udebug.active != true) {
-                LOG("- udebug.active: %s, udebug.go: %s\n",
-                        THREAD->udebug.active ? "yes(+)" : "no(-)",
-                        THREAD->udebug.go ? "yes(-)" : "no(+)");
+                LOG("udebug.active: %s, udebug.go: %s",
+                        THREAD->udebug.active ? "Yes(+)" : "No",
+                        THREAD->udebug.go ? "Yes(-)" : "No");
                 mutex_unlock(&THREAD->udebug.lock);
                 mutex_unlock(&TASK->udebug.lock);
@@ -343 +341 @@
         }
 
-        LOG("- trigger event\n");
-
+        LOG("Trigger event");
         call = THREAD->udebug.go_call;
         THREAD->udebug.go_call = NULL;
@@ -364 +361 @@
         mutex_unlock(&TASK->udebug.lock);
 
-        LOG("- sleep\n");
+        LOG("Wait for Go");
         udebug_wait_for_go(&THREAD->udebug.go_wq);
 }
@@ -380 +377 @@
         mutex_lock(&THREAD->udebug.lock);
 
-        LOG("udebug_thread_e_event\n");
-        LOG("- check state\n");
+        LOG("Check state");
 
         /* Must only generate events when in debugging session. */
         if (THREAD->udebug.active != true) {
-/*              printf("- udebug.active: %s, udebug.go: %s\n",
-                        THREAD->udebug.active ? "yes(+)" : "no(-)",
-                        THREAD->udebug.go ? "yes(-)" : "no(+)");*/
+                LOG("udebug.active: %s, udebug.go: %s",
+                        THREAD->udebug.active ? "Yes" : "No",
+                        THREAD->udebug.go ? "Yes" : "No");
                 mutex_unlock(&THREAD->udebug.lock);
                 mutex_unlock(&TASK->udebug.lock);
@@ -393 +389 @@
         }
 
-        LOG("- trigger event\n");
-
+        LOG("Trigger event");
         call = THREAD->udebug.go_call;
         THREAD->udebug.go_call = NULL;
@@ -433 +428 @@
         ipl_t ipl;
 
-        LOG("udebug_task_cleanup()\n");
-        LOG("task %" PRIu64 "\n", ta->taskid);
-
         if (ta->udebug.dt_state != UDEBUG_TS_BEGINNING &&
             ta->udebug.dt_state != UDEBUG_TS_ACTIVE) {
-                LOG("udebug_task_cleanup(): task not being debugged\n");
                 return EINVAL;
         }
+
+        LOG("Task %" PRIu64, ta->taskid);
 
         /* Finish debugging of all userspace threads */
@@ -471 +464 @@
 
                                 /* Answer GO call */
-                                LOG("answer GO call with EVENT_FINISHED\n");
+                                LOG("Answer GO call with EVENT_FINISHED.");
                                 IPC_SET_RETVAL(t->udebug.go_call->data, 0);
                                 IPC_SET_ARG1(t->udebug.go_call->data,