Changeset add04f7 in mainline for kernel/arch/ia32/include/atomic.h

Timestamp:

2009-03-03T15:20:49Z (16 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f24d300

Parents:

deca67b

Message:

better inline assembler readability using the new symbolic syntax

File:

• kernel/arch/ia32/include/atomic.h (modified) (8 diffs)

kernel/arch/ia32/include/atomic.h

@@ -27 +27 @@
  */
 
-/** @addtogroup ia32    
+/** @addtogroup ia32
  * @{
  */
@@ -42 +42 @@
 static inline void atomic_inc(atomic_t *val) {
 #ifdef CONFIG_SMP
-        asm volatile ("lock incl %0\n" : "+m" (val->count));
+        asm volatile (
+                "lock incl %[count]\n"
+                : [count] "+m" (val->count)
+        );
 #else
-        asm volatile ("incl %0\n" : "+m" (val->count));
+        asm volatile (
+                "incl %[count]\n"
+                : [count] "+m" (val->count)
+        );
 #endif /* CONFIG_SMP */
 }
@@ -50 +56 @@
 static inline void atomic_dec(atomic_t *val) {
 #ifdef CONFIG_SMP
-        asm volatile ("lock decl %0\n" : "+m" (val->count));
+        asm volatile (
+                "lock decl %[count]\n"
+                : [count] "+m" (val->count)
+        );
 #else
-        asm volatile ("decl %0\n" : "+m" (val->count));
+        asm volatile (
+                "decl %[count]\n"
+                : "+m" (val->count)
+        );
 #endif /* CONFIG_SMP */
 }
@@ -59 +71 @@
 {
         long r = 1;
-
+        
         asm volatile (
-                "lock xaddl %1, %0\n"
-                : "+m" (val->count), "+r" (r)
+                "lock xaddl %[r], %[count]\n"
+                : [count] "+m" (val->count), [r] "+r" (r)
         );
-
+        
         return r;
 }
@@ -73 +85 @@
         
         asm volatile (
-                "lock xaddl %1, %0\n"
-                : "+m" (val->count), "+r"(r)
+                "lock xaddl %[r], %[count]\n"
+                : [count] "+m" (val->count), [r] "+r"(r)
         );
         
@@ -80 +92 @@
 }
 
-#define atomic_preinc(val) (atomic_postinc(val) + 1)
-#define atomic_predec(val) (atomic_postdec(val) - 1)
+#define atomic_preinc(val)  (atomic_postinc(val) + 1)
+#define atomic_predec(val)  (atomic_postdec(val) - 1)
 
 static inline uint32_t test_and_set(atomic_t *val) {
@@ -87 +99 @@
         
         asm volatile (
-                "movl $1, %0\n"
-                "xchgl %0, %1\n"
-                : "=r" (v),"+m" (val->count)
+                "movl $1, %[v]\n"
+                "xchgl %[v], %[count]\n"
+                : [v] "=r" (v), [count] "+m" (val->count)
         );
         
@@ -99 +111 @@
 {
         uint32_t tmp;
-
+        
         preemption_disable();
         asm volatile (
                 "0:\n"
 #ifdef CONFIG_HT
-                "pause\n" /* Pentium 4's HT love this instruction */
+                "pause\n"        /* Pentium 4's HT love this instruction */
 #endif
-                "mov %0, %1\n"
-                "testl %1, %1\n"
+                "mov %[count], %[tmp]\n"
+                "testl %[tmp], %[tmp]\n"
                 "jnz 0b\n"       /* lightweight looping on locked spinlock */
                 
-                "incl %1\n"      /* now use the atomic operation */
-                "xchgl %0, %1\n"        
-                "testl %1, %1\n"
+                "incl %[tmp]\n"  /* now use the atomic operation */
+                "xchgl %[count], %[tmp]\n"
+                "testl %[tmp], %[tmp]\n"
                 "jnz 0b\n"
-                : "+m" (val->count), "=&r"(tmp)
+                : [count] "+m" (val->count), [tmp] "=&r" (tmp)
         );
         /*