Changeset a7199c2 in mainline for kernel/generic/src/console/kconsole.c

Timestamp:

2010-07-13T21:12:11Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c0e9f3f

Parents:

b62d5614

Message:

Reduce kconsole stack space consumption by about 2.5KiB by using dynamically
allocated buffers. This fixes a couple of problems seen when running some
kconsole commands on e.g. amd64 in which the 4KiB stack was just too small.

File:

• kernel/generic/src/console/kconsole.c (modified) (8 diffs)

kernel/generic/src/console/kconsole.c

@@ -210 +210 @@
         link_t *pos = NULL;
         const char *hint;
-        char output[MAX_CMDLINE];
+        char *output = malloc(MAX_CMDLINE, 0);
         
         output[0] = 0;
@@ -235 +235 @@
                 str_cpy(input, size, output);
         
+        free(output);
         return found;
 }
@@ -245 +246 @@
         wchar_t *current = history[history_pos];
         current[0] = 0;
+        char *tmp = malloc(STR_BOUNDS(MAX_CMDLINE), 0);
         
         while (true) {
@@ -289 +291 @@
                                 beg++;
                         
-                        char tmp[STR_BOUNDS(MAX_CMDLINE)];
                         wstr_to_str(tmp, position - beg + 1, current + beg);
                         
@@ -415 +416 @@
         }
         
+        free(tmp);
         return current;
 }
@@ -688 +690 @@
                 printf("Type \"exit\" to leave the console.\n");
         
+        char *cmdline = malloc(STR_BOUNDS(MAX_CMDLINE), 0);
         while (true) {
                 wchar_t *tmp = clever_readline((char *) prompt, stdin);
@@ -694 +697 @@
                         continue;
                 
-                char cmdline[STR_BOUNDS(MAX_CMDLINE)];
                 wstr_to_str(cmdline, STR_BOUNDS(MAX_CMDLINE), tmp);
                 
@@ -706 +708 @@
                 (void) cmd_info->func(cmd_info->argv);
         }
+        free(cmdline);
 }