Changeset a46e56b in mainline for uspace/lib/drv/generic/remote_clock_dev.c

Timestamp:

2018-03-22T06:49:35Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/lib/drv/generic/remote_clock_dev.c (modified) (5 diffs)

uspace/lib/drv/generic/remote_clock_dev.c

@@ -69 +69 @@
  */
 static void
-remote_clock_time_get(ddf_fun_t *fun, void *ops, cap_call_handle_t callid,
+remote_clock_time_get(ddf_fun_t *fun, void *ops, cap_call_handle_t chandle,
     ipc_call_t *call)
 {
         clock_dev_ops_t *clock_dev_ops = (clock_dev_ops_t *) ops;
-        cap_call_handle_t cid;
+        cap_call_handle_t call_handle;
         struct tm t;
         errno_t rc;
         size_t len;
 
-        if (!async_data_read_receive(&cid, &len)) {
+        if (!async_data_read_receive(&call_handle, &len)) {
                 /* TODO: Handle protocol error */
-                async_answer_0(callid, EINVAL);
+                async_answer_0(chandle, EINVAL);
                 return;
         }
@@ -86 +86 @@
         if (!clock_dev_ops->time_get) {
                 /* The driver does not provide the time_get() functionality */
-                async_answer_0(cid, ENOTSUP);
-                async_answer_0(callid, ENOTSUP);
+                async_answer_0(call_handle, ENOTSUP);
+                async_answer_0(chandle, ENOTSUP);
                 return;
         }
@@ -95 +95 @@
         if (rc != EOK) {
                 /* Some error occurred */
-                async_answer_0(cid, rc);
-                async_answer_0(callid, rc);
+                async_answer_0(call_handle, rc);
+                async_answer_0(chandle, rc);
                 return;
         }
 
         /* The operation was successful */
-        async_data_read_finalize(cid, &t, sizeof(struct tm));
-        async_answer_0(callid, rc);
+        async_data_read_finalize(call_handle, &t, sizeof(struct tm));
+        async_answer_0(chandle, rc);
 }
 
@@ -111 +111 @@
  */
 static void remote_clock_time_set(ddf_fun_t *fun, void *ops,
-    cap_call_handle_t callid, ipc_call_t *call)
+    cap_call_handle_t chandle, ipc_call_t *call)
 {
         clock_dev_ops_t *clock_dev_ops = (clock_dev_ops_t *) ops;
         errno_t      rc;
         struct tm    t;
-        cap_call_handle_t cid;
+        cap_call_handle_t call_handle;
         size_t       len;
 
-        if (!async_data_write_receive(&cid, &len)) {
+        if (!async_data_write_receive(&call_handle, &len)) {
                 /* TODO: Handle protocol error */
-                async_answer_0(callid, EINVAL);
+                async_answer_0(chandle, EINVAL);
                 return;
         }
@@ -127 +127 @@
         if (!clock_dev_ops->time_set) {
                 /* The driver does not support the time_set() functionality */
-                async_answer_0(cid, ENOTSUP);
-                async_answer_0(callid, ENOTSUP);
+                async_answer_0(call_handle, ENOTSUP);
+                async_answer_0(chandle, ENOTSUP);
                 return;
         }
 
-        async_data_write_finalize(cid, &t, sizeof(struct tm));
+        async_data_write_finalize(call_handle, &t, sizeof(struct tm));
 
         rc = (*clock_dev_ops->time_set)(fun, &t);
 
-        async_answer_0(callid, rc);
+        async_answer_0(chandle, rc);
 }