Changeset a46e56b in mainline for uspace/lib/c/generic/inetping.c

Timestamp:

2018-03-22T06:49:35Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

77f0a1d

Parents:

3e242d2

git-author:

Jakub Jermar <jakub@…> (2018-03-21 23:29:06)

git-committer:

Jakub Jermar <jakub@…> (2018-03-22 06:49:35)

Message:

Prefer handle over ID in naming handle variables

File:

• uspace/lib/c/generic/inetping.c (modified) (5 diffs)

uspace/lib/c/generic/inetping.c

@@ -150 +150 @@
 }
 
-static void inetping_ev_recv(cap_call_handle_t iid, ipc_call_t *icall)
+static void inetping_ev_recv(cap_call_handle_t icall_handle, ipc_call_t *icall)
 {
         inetping_sdu_t sdu;
@@ -156 +156 @@
         sdu.seq_no = IPC_GET_ARG1(*icall);
 
-        cap_call_handle_t callid;
+        cap_call_handle_t chandle;
         size_t size;
-        if (!async_data_write_receive(&callid, &size)) {
-                async_answer_0(callid, EREFUSED);
-                async_answer_0(iid, EREFUSED);
+        if (!async_data_write_receive(&chandle, &size)) {
+                async_answer_0(chandle, EREFUSED);
+                async_answer_0(icall_handle, EREFUSED);
                 return;
         }
 
         if (size != sizeof(sdu.src)) {
-                async_answer_0(callid, EINVAL);
-                async_answer_0(iid, EINVAL);
-                return;
-        }
-
-        errno_t rc = async_data_write_finalize(callid, &sdu.src, size);
-        if (rc != EOK) {
-                async_answer_0(callid, rc);
-                async_answer_0(iid, rc);
-                return;
-        }
-
-        if (!async_data_write_receive(&callid, &size)) {
-                async_answer_0(callid, EREFUSED);
-                async_answer_0(iid, EREFUSED);
+                async_answer_0(chandle, EINVAL);
+                async_answer_0(icall_handle, EINVAL);
+                return;
+        }
+
+        errno_t rc = async_data_write_finalize(chandle, &sdu.src, size);
+        if (rc != EOK) {
+                async_answer_0(chandle, rc);
+                async_answer_0(icall_handle, rc);
+                return;
+        }
+
+        if (!async_data_write_receive(&chandle, &size)) {
+                async_answer_0(chandle, EREFUSED);
+                async_answer_0(icall_handle, EREFUSED);
                 return;
         }
 
         if (size != sizeof(sdu.dest)) {
-                async_answer_0(callid, EINVAL);
-                async_answer_0(iid, EINVAL);
-                return;
-        }
-
-        rc = async_data_write_finalize(callid, &sdu.dest, size);
-        if (rc != EOK) {
-                async_answer_0(callid, rc);
-                async_answer_0(iid, rc);
+                async_answer_0(chandle, EINVAL);
+                async_answer_0(icall_handle, EINVAL);
+                return;
+        }
+
+        rc = async_data_write_finalize(chandle, &sdu.dest, size);
+        if (rc != EOK) {
+                async_answer_0(chandle, rc);
+                async_answer_0(icall_handle, rc);
                 return;
         }
@@ -198 +198 @@
         rc = async_data_write_accept(&sdu.data, false, 0, 0, 0, &sdu.size);
         if (rc != EOK) {
-                async_answer_0(iid, rc);
+                async_answer_0(icall_handle, rc);
                 return;
         }
@@ -204 +204 @@
         rc = inetping_ev_ops->recv(&sdu);
         free(sdu.data);
-        async_answer_0(iid, rc);
-}
-
-static void inetping_cb_conn(cap_call_handle_t iid, ipc_call_t *icall, void *arg)
+        async_answer_0(icall_handle, rc);
+}
+
+static void inetping_cb_conn(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg)
 {
         while (true) {
                 ipc_call_t call;
-                cap_call_handle_t callid = async_get_call(&call);
+                cap_call_handle_t chandle = async_get_call(&call);
 
                 if (!IPC_GET_IMETHOD(call)) {
@@ -220 +220 @@
                 switch (IPC_GET_IMETHOD(call)) {
                 case INETPING_EV_RECV:
-                        inetping_ev_recv(callid, &call);
+                        inetping_ev_recv(chandle, &call);
                         break;
                 default:
-                        async_answer_0(callid, ENOTSUP);
+                        async_answer_0(chandle, ENOTSUP);
                 }
         }