Changeset a35b458 in mainline for kernel/arch/arm32/src/asm.S


Ignore:
Timestamp:
2018-03-02T20:10:49Z (6 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • kernel/arch/arm32/src/asm.S

    r3061bc1 ra35b458  
    3939        mov r5, r0 /* save dst */
    4040        beq 4f
    41        
     41
    4242        1:
    4343                cmp r2, #0
    4444                movne ip, #0
    4545                beq 3f
    46        
     46
    4747        2:
    4848                ldrb r3, [ip, r1]
     
    5151                cmp ip, r2
    5252                bne 2b
    53        
     53
    5454        3:
    5555                mov r0, r5
    5656                ldmia sp!, {r4, r5, pc}
    57        
     57
    5858        4:
    5959                add r3, r0, #3
     
    6666                mov lr, #0
    6767                mov ip, lr
    68        
     68
    6969        5:
    7070                ldr r3, [ip, r1]
     
    7474                add ip, ip, #4
    7575                bne 5b
    76        
     76
    7777        6:
    7878                ands r4, r2, #3
     
    8282                add ip, r3, r1
    8383                mov r2, #0
    84        
     84
    8585        7:
    8686                ldrb r3, [r2, ip]
Note: See TracChangeset for help on using the changeset viewer.