Changeset a1732929 in mainline for uspace/lib/usbhid/src/hiddescriptor.c

Timestamp:

2018-01-15T17:04:34Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

File:

• uspace/lib/usbhid/src/hiddescriptor.c (modified) (3 diffs)

uspace/lib/usbhid/src/hiddescriptor.c

@@ -881 +881 @@
 {
         if(list == NULL || list_empty(list)) {
-            usb_log_debug("\tempty\n");
+            usb_log_debug("\tempty");
             return;
         }
@@ -887 +887 @@
         list_foreach(*list, ritems_link, usb_hid_report_field_t,
             report_item) {
-                usb_log_debug("\t\tOFFSET: %u\n", report_item->offset);
-                usb_log_debug("\t\tSIZE: %zu\n", report_item->size);
-                usb_log_debug("\t\tLOGMIN: %d\n",
+                usb_log_debug("\t\tOFFSET: %u", report_item->offset);
+                usb_log_debug("\t\tSIZE: %zu", report_item->size);
+                usb_log_debug("\t\tLOGMIN: %d",
                         report_item->logical_minimum);
-                usb_log_debug("\t\tLOGMAX: %d\n",
+                usb_log_debug("\t\tLOGMAX: %d",
                         report_item->logical_maximum);
-                usb_log_debug("\t\tPHYMIN: %d\n",
+                usb_log_debug("\t\tPHYMIN: %d",
                         report_item->physical_minimum);
-                usb_log_debug("\t\tPHYMAX: %d\n",
+                usb_log_debug("\t\tPHYMAX: %d",
                         report_item->physical_maximum);
-                usb_log_debug("\t\ttUSAGEMIN: %X\n",
+                usb_log_debug("\t\ttUSAGEMIN: %X",
                         report_item->usage_minimum);
-                usb_log_debug("\t\tUSAGEMAX: %X\n",
+                usb_log_debug("\t\tUSAGEMAX: %X",
                                report_item->usage_maximum);
-                usb_log_debug("\t\tUSAGES COUNT: %zu\n",
+                usb_log_debug("\t\tUSAGES COUNT: %zu",
                         report_item->usages_count);
 
-                usb_log_debug("\t\tVALUE: %X\n", report_item->value);
-                usb_log_debug("\t\ttUSAGE: %X\n", report_item->usage);
-                usb_log_debug("\t\tUSAGE PAGE: %X\n", report_item->usage_page);
+                usb_log_debug("\t\tVALUE: %X", report_item->value);
+                usb_log_debug("\t\ttUSAGE: %X", report_item->usage);
+                usb_log_debug("\t\tUSAGE PAGE: %X", report_item->usage_page);
 
                 usb_hid_print_usage_path(report_item->collection_path);
-
-                usb_log_debug("\n");
         }
 }
@@ -928 +926 @@
         list_foreach(report->reports, reports_link,
             usb_hid_report_description_t, report_des) {
-                usb_log_debug("Report ID: %d\n", report_des->report_id);
-                usb_log_debug("\tType: %d\n", report_des->type);
-                usb_log_debug("\tLength: %zu\n", report_des->bit_length);
-                usb_log_debug("\tB Size: %zu\n",
+                usb_log_debug("Report ID: %d", report_des->report_id);
+                usb_log_debug("\tType: %d", report_des->type);
+                usb_log_debug("\tLength: %zu", report_des->bit_length);
+                usb_log_debug("\tB Size: %zu",
                         usb_hid_report_byte_size(report,
                                 report_des->report_id,
                                 report_des->type));
-                usb_log_debug("\tItems: %zu\n", report_des->item_length);
+                usb_log_debug("\tItems: %zu", report_des->item_length);
 
                 usb_hid_descriptor_print_list(&report_des->report_items);