Changeset 9cfbf2f in mainline for uspace/srv/ns/clonable.c

Timestamp:

2015-08-22T03:53:34Z (9 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

57dea62

Parents:

1a522e5

Message:

improve code readability
coding style

File:

• uspace/srv/ns/clonable.c (modified) (7 diffs)

uspace/srv/ns/clonable.c

@@ -46 +46 @@
 typedef struct {
         link_t link;
-        sysarg_t service;
-        ipc_call_t call;
+        service_t service;
+        iface_t iface;
         ipc_callid_t callid;
+        sysarg_t arg3;
 } cs_req_t;
 
@@ -61 +62 @@
 
 /** Return true if @a service is clonable. */
-bool service_clonable(int service)
+bool service_clonable(service_t service)
 {
         return (service == SERVICE_LOAD);
@@ -73 +74 @@
  *
  */
-void register_clonable(sysarg_t service, sysarg_t phone, ipc_call_t *call,
+void register_clonable(service_t service, sysarg_t phone, ipc_call_t *call,
     ipc_callid_t callid)
 {
-        link_t *req_link;
-
-        req_link = list_first(&cs_req);
+        link_t *req_link = list_first(&cs_req);
         if (req_link == NULL) {
                 /* There was no pending connection request. */
@@ -94 +93 @@
         ipc_answer_0(callid, EOK);
         
-        ipc_forward_fast(csr->callid, phone, IPC_GET_ARG1(csr->call),
-            IPC_GET_ARG3(csr->call), 0, IPC_FF_NONE);
+        ipc_forward_fast(csr->callid, phone, csr->iface, csr->arg3, 0,
+            IPC_FF_NONE);
         
         free(csr);
@@ -104 +103 @@
  *
  * @param service Service to be connected to.
+ * @param iface   Interface to be connected to.
  * @param call    Pointer to call structure.
  * @param callid  Call ID of the request.
@@ -110 +110 @@
  *
  */
-void connect_to_clonable(sysarg_t service, ipc_call_t *call,
+void connect_to_clonable(service_t service, iface_t iface, ipc_call_t *call,
     ipc_callid_t callid)
 {
@@ -132 +132 @@
         link_initialize(&csr->link);
         csr->service = service;
-        csr->call = *call;
+        csr->iface = iface;
         csr->callid = callid;
+        csr->arg3 = IPC_GET_ARG3(*call);
         
         /*