Changeset 9b1baac in mainline for uspace/srv/ns/clonable.c

Timestamp:

2018-07-18T08:35:42Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0b05082

Parents:

edc64c0

Message:

ns: register service interfaces individually

Each service interface is now registered individually with the naming
service. This adds a degree of type safety, potentially allows the
individual interfaces to be implemented by independent tasks and moves
the code slightly closer to the full-fledged ports design.

Broker services (e.g. the location service) can still register a
fallback port for receiving connections to all interface types
explicitly using service_register_broker().

File:

• uspace/srv/ns/clonable.c (modified) (4 diffs)

uspace/srv/ns/clonable.c

@@ -54 +54 @@
 static list_t cs_req;
 
-errno_t clonable_init(void)
+errno_t ns_clonable_init(void)
 {
         list_initialize(&cs_req);
@@ -61 +61 @@
 
 /** Return true if @a service is clonable. */
-bool service_clonable(service_t service)
+bool ns_service_is_clonable(service_t service, iface_t iface)
 {
-        return (service == SERVICE_LOADER);
+        return (service == SERVICE_LOADER) && (iface == INTERFACE_LOADER);
 }
 
 /** Register clonable service.
  *
- * @param service Service to be registered.
- * @param phone   Phone to be used for connections to the service.
- * @param call    Pointer to call structure.
+ * @param call Pointer to call structure.
  *
  */
-void register_clonable(service_t service, sysarg_t phone, ipc_call_t *call)
+void ns_clonable_register(ipc_call_t *call)
 {
         link_t *req_link = list_first(&cs_req);
@@ -87 +85 @@
 
         /* Currently we can only handle a single type of clonable service. */
-        assert(csr->service == SERVICE_LOADER);
+        assert(ns_service_is_clonable(csr->service, csr->iface));
 
         async_answer_0(call, EOK);
@@ -113 +111 @@
  *
  */
-void connect_to_clonable(service_t service, iface_t iface, ipc_call_t *call)
+void ns_clonable_forward(service_t service, iface_t iface, ipc_call_t *call)
 {
-        assert(service == SERVICE_LOADER);
+        assert(ns_service_is_clonable(service, iface));
 
         cs_req_t *csr = malloc(sizeof(cs_req_t));