Changeset 9b1baac in mainline for uspace/srv/logger/main.c

Timestamp:

2018-07-18T08:35:42Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0b05082

Parents:

edc64c0

Message:

ns: register service interfaces individually

Each service interface is now registered individually with the naming
service. This adds a degree of type safety, potentially allows the
individual interfaces to be implemented by independent tasks and moves
the code slightly closer to the full-fledged ports design.

Broker services (e.g. the location service) can still register a
fallback port for receiving connections to all interface types
explicitly using service_register_broker().

File:

• uspace/srv/logger/main.c (modified) (1 diff)

uspace/srv/logger/main.c

@@ -67 +67 @@
         }
 
-        port_id_t port;
-        errno_t rc = async_create_port(INTERFACE_LOGGER_CONTROL,
-            connection_handler_control, NULL, &port);
+        errno_t rc = service_register(SERVICE_LOGGER, INTERFACE_LOGGER_CONTROL,
+            connection_handler_control, NULL);
         if (rc != EOK) {
-                printf("%s: Error while creating control port: %s\n", NAME, str_error(rc));
-                return rc;
-        }
-
-        rc = async_create_port(INTERFACE_LOGGER_WRITER,
-            connection_handler_writer, NULL, &port);
-        if (rc != EOK) {
-                printf("%s: Error while creating writer port: %s\n", NAME, str_error(rc));
-                return rc;
-        }
-
-        rc = service_register(SERVICE_LOGGER);
-        if (rc != EOK) {
-                printf(NAME ": failed to register: %s.\n", str_error(rc));
+                printf("%s: Failed to register control port: %s.\n", NAME,
+                    str_error(rc));
                 return -1;
         }
 
-        printf(NAME ": Accepting connections\n");
+        rc = service_register(SERVICE_LOGGER, INTERFACE_LOGGER_WRITER,
+            connection_handler_writer, NULL);
+        if (rc != EOK) {
+                printf("%s: Failed to register writer port: %s.\n", NAME,
+                    str_error(rc));
+                return -1;
+        }
+
+        printf("%s: Accepting connections\n", NAME);
         async_manager();