Changeset 984a9ba in mainline for uspace/srv/hid/s3c24xx_ts/s3c24xx_ts.c

Timestamp:

2018-07-05T09:34:09Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

File:

• uspace/srv/hid/s3c24xx_ts/s3c24xx_ts.c (modified) (4 diffs)

uspace/srv/hid/s3c24xx_ts/s3c24xx_ts.c

@@ -69 +69 @@
 static s3c24xx_ts_t *ts;
 
-static void s3c24xx_ts_connection(cap_call_handle_t icall_handle, ipc_call_t *icall,
-    void *arg);
-static void s3c24xx_ts_irq_handler(ipc_call_t *call, void *);
-static void s3c24xx_ts_pen_down(s3c24xx_ts_t *ts);
-static void s3c24xx_ts_pen_up(s3c24xx_ts_t *ts);
-static void s3c24xx_ts_eoc(s3c24xx_ts_t *ts);
-static int s3c24xx_ts_init(s3c24xx_ts_t *ts);
-static void s3c24xx_ts_wait_for_int_mode(s3c24xx_ts_t *ts, ts_updn_t updn);
-static void s3c24xx_ts_convert_samples(int smp0, int smp1, int *x, int *y);
-static int lin_map_range(int v, int i0, int i1, int o0, int o1);
+static void s3c24xx_ts_connection(ipc_call_t *, void *);
+static void s3c24xx_ts_irq_handler(ipc_call_t *, void *);
+static void s3c24xx_ts_pen_down(s3c24xx_ts_t *);
+static void s3c24xx_ts_pen_up(s3c24xx_ts_t *);
+static void s3c24xx_ts_eoc(s3c24xx_ts_t *);
+static int s3c24xx_ts_init(s3c24xx_ts_t *);
+static void s3c24xx_ts_wait_for_int_mode(s3c24xx_ts_t *, ts_updn_t);
+static void s3c24xx_ts_convert_samples(int, int, int *, int *);
+static int lin_map_range(int, int, int, int, int);
 
 int main(int argc, char *argv[])
@@ -371 +370 @@
 
 /** Handle mouse client connection. */
-static void s3c24xx_ts_connection(cap_call_handle_t icall_handle, ipc_call_t *icall,
-    void *arg)
-{
-        async_answer_0(icall_handle, EOK);
+static void s3c24xx_ts_connection(ipc_call_t *icall, void *arg)
+{
+        async_answer_0(icall, EOK);
 
         while (true) {
                 ipc_call_t call;
-                cap_call_handle_t chandle = async_get_call(&call);
+                async_get_call(&call);
 
                 if (!IPC_GET_IMETHOD(call)) {
@@ -386 +384 @@
                         }
 
-                        async_answer_0(chandle, EOK);
+                        async_answer_0(&call, EOK);
                         return;
                 }
@@ -395 +393 @@
                         if (ts->client_sess == NULL) {
                                 ts->client_sess = sess;
-                                async_answer_0(chandle, EOK);
+                                async_answer_0(&call, EOK);
                         } else
-                                async_answer_0(chandle, ELIMIT);
+                                async_answer_0(&call, ELIMIT);
                 } else
-                        async_answer_0(chandle, EINVAL);
+                        async_answer_0(&call, EINVAL);
         }
 }