Changeset 984a9ba in mainline for uspace/srv/audio/hound/audio_device.c

Timestamp:

2018-07-05T09:34:09Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

File:

• uspace/srv/audio/hound/audio_device.c (modified) (3 diffs)

uspace/srv/audio/hound/audio_device.c

@@ -54 +54 @@
 static errno_t device_sink_connection_callback(audio_sink_t *sink, bool new);
 static errno_t device_source_connection_callback(audio_source_t *source, bool new);
-static void device_event_callback(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg);
+static void device_event_callback(ipc_call_t *icall, void *arg);
 static errno_t device_check_format(audio_sink_t *sink);
 static errno_t get_buffer(audio_device_t *dev);
@@ -260 +260 @@
 /** Audio device event handler.
  *
- * @param icall_handle  Initial call handle.
- * @param icall         Initial call structure.
- * @param arg           (unused)
- */
-static void device_event_callback(cap_call_handle_t icall_handle,
-    ipc_call_t *icall, void *arg)
+ * @param icall Initial call structure.
+ * @param arg   (unused)
+ *
+ */
+static void device_event_callback(ipc_call_t *icall, void *arg)
 {
         struct timeval time1;
@@ -271 +270 @@
 
         /* Answer initial request */
-        async_answer_0(icall_handle, EOK);
+        async_answer_0(icall, EOK);
         audio_device_t *dev = arg;
         assert(dev);
         while (true) {
                 ipc_call_t call;
-                cap_call_handle_t chandle = async_get_call(&call);
-                async_answer_0(chandle, EOK);
+                async_get_call(&call);
+                async_answer_0(&call, EOK);
+
                 switch (IPC_GET_IMETHOD(call)) {
                 case PCM_EVENT_FRAMES_PLAYED: