Changeset 984a9ba in mainline for uspace/lib/usbvirt/src/device.c

Timestamp:

2018-07-05T09:34:09Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

File:

• uspace/lib/usbvirt/src/device.c (modified) (1 diff)

uspace/lib/usbvirt/src/device.c

@@ -50 +50 @@
 /** Main IPC call handling from virtual host controller.
  *
- * @param iid   Caller identification
  * @param icall Initial incoming call
  * @param arg   Local argument
+ *
  */
-static void callback_connection(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg)
+static void callback_connection(ipc_call_t *icall, void *arg)
 {
         assert(DEV != NULL);
 
-        async_answer_0(icall_handle, EOK);
+        async_answer_0(icall, EOK);
 
         while (true) {
-                cap_call_handle_t chandle;
                 ipc_call_t call;
+                async_get_call(&call);
 
-                chandle = async_get_call(&call);
-                bool processed = usbvirt_ipc_handle_call(DEV, chandle, &call);
+                bool processed = usbvirt_ipc_handle_call(DEV, &call);
                 if (!processed) {
                         if (!IPC_GET_IMETHOD(call)) {
-                                async_answer_0(chandle, EOK);
+                                async_answer_0(&call, EOK);
                                 return;
                         } else
-                                async_answer_0(chandle, EINVAL);
+                                async_answer_0(&call, EINVAL);
                 }
         }