Changeset 984a9ba in mainline for uspace/drv/char/ns8250/ns8250.c

Timestamp:

2018-07-05T09:34:09Z (6 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

63d46341

Parents:

76f566d

Message:

do not expose the call capability handler from the async framework

Keep the call capability handler encapsulated within the async framework
and do not expose it explicitly via its API. Use the pointer to
ipc_call_t as the sole object identifying an IPC call in the code that
uses the async framework.

This plugs a major leak in the abstraction and also simplifies both the
async framework (slightly) and all IPC servers.

File:

• uspace/drv/char/ns8250/ns8250.c (modified) (5 diffs)

uspace/drv/char/ns8250/ns8250.c

@@ -311 +311 @@
 static errno_t ns8250_open(chardev_srvs_t *, chardev_srv_t *);
 static errno_t ns8250_close(chardev_srv_t *);
-static void ns8250_default_handler(chardev_srv_t *, cap_call_handle_t, ipc_call_t *);
+static void ns8250_default_handler(chardev_srv_t *, ipc_call_t *);
 
 /** The character interface's callbacks. */
@@ -322 +322 @@
 };
 
-static void ns8250_char_conn(cap_call_handle_t, ipc_call_t *, void *);
+static void ns8250_char_conn(ipc_call_t *, void *);
 
 static errno_t ns8250_dev_add(ddf_dev_t *dev);
@@ -1067 +1067 @@
  * Configure the parameters of the serial communication.
  */
-static void ns8250_default_handler(chardev_srv_t *srv, cap_call_handle_t chandle,
-    ipc_call_t *call)
+static void ns8250_default_handler(chardev_srv_t *srv, ipc_call_t *call)
 {
         ns8250_t *ns8250 = srv_ns8250(srv);
@@ -1079 +1078 @@
                 ns8250_get_props(ns8250->dev, &baud_rate, &parity, &word_length,
                     &stop_bits);
-                async_answer_4(chandle, EOK, baud_rate, parity, word_length,
+                async_answer_4(call, EOK, baud_rate, parity, word_length,
                     stop_bits);
                 break;
@@ -1090 +1089 @@
                 ret = ns8250_set_props(ns8250->dev, baud_rate, parity, word_length,
                     stop_bits);
-                async_answer_0(chandle, ret);
+                async_answer_0(call, ret);
                 break;
 
         default:
-                async_answer_0(chandle, ENOTSUP);
-        }
-}
-
-void ns8250_char_conn(cap_call_handle_t icall_handle, ipc_call_t *icall, void *arg)
+                async_answer_0(call, ENOTSUP);
+        }
+}
+
+void ns8250_char_conn(ipc_call_t *icall, void *arg)
 {
         ns8250_t *ns8250 = fun_ns8250((ddf_fun_t *)arg);
 
-        chardev_conn(icall_handle, icall, &ns8250->cds);
+        chardev_conn(icall, &ns8250->cds);
 }