Changeset 88ad75f in mainline for uspace/srv/sysman/main.c

Timestamp:

2020-01-09T01:04:57Z (4 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

76c8209

Parents:

0939097

git-author:

Matthieu Riolo <matthieu.riolo@…> (2020-01-05 19:24:23)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2020-01-09 01:04:57)

Message:

repo_add_unit() returned an errno_t but it was never handled. This
commit adds a check if EOK is returned or else the repo will be left
unchanged

File:

• uspace/srv/sysman/main.c (modified) (1 diff)

uspace/srv/sysman/main.c

@@ -135 +135 @@
         repo_begin_update();
 
-        repo_add_unit(mnt_initrd);
-        repo_add_unit(cfg_init);
-        repo_add_unit(tgt_init);
+        rc = repo_add_unit(mnt_initrd);
+        if (rc != EOK)
+                goto rollback;
+        rc = repo_add_unit(cfg_init);
+        if (rc != EOK)
+                goto rollback;
+        rc = repo_add_unit(tgt_init);
+        if (rc != EOK)
+                goto rollback;
 
         rc = edge_connect(tgt_init, cfg_init);
-        if (rc != EOK) {
-                goto rollback;
-        }
+        if (rc != EOK)
+                goto rollback;
 
         rc = edge_connect(cfg_init, mnt_initrd);
-        if (rc != EOK) {
-                goto rollback;
-        }
+        if (rc != EOK)
+                goto rollback;
 
         repo_commit();
-
         return EOK;