Changeset 87e9392 in mainline for uspace/srv/logger/logs.c

Timestamp:

2012-10-08T06:16:46Z (12 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

062d900, d1ef4a1

Parents:

000494d

Message:

Prevent fclose(NULL) in logger (#498)

File:

• uspace/srv/logger/logs.c (modified) (1 diff)

uspace/srv/logger/logs.c

@@ -268 +268 @@
 
         if (log->parent == NULL) {
-                fclose(log->dest->logfile);
+                /*
+                 * Due to lazy file opening in write_to_log(),
+                 * it is possible that no file was actually opened.
+                 */
+                if (log->dest->logfile != NULL) {
+                        fclose(log->dest->logfile);
+                }
                 free(log->dest->filename);
                 free(log->dest);